Skip to content

fix(inflection): expand compound *base word exceptions (codebases → codebase)#54

Merged
pyramation merged 1 commit intomainfrom
devin/1774842759-fix-inflection-compound-base
Mar 30, 2026
Merged

fix(inflection): expand compound *base word exceptions (codebases → codebase)#54
pyramation merged 1 commit intomainfrom
devin/1774842759-fix-inflection-compound-base

Conversation

@pyramation
Copy link
Copy Markdown
Contributor

Summary

Expands the existing (database)s$ exception rule to also cover codebase, firebase, and knowledgebase. Without this, the (b)a branch in the ses$ singular rule greedily matches the "ba" inside these compound words, producing incorrect singularizations like codebases → codebasis instead of codebases → codebase.

Both the deploy fixture and compiled SQL are updated identically (plural guard + singular replacement).

Review & Testing Checklist for Human

  • Verify no other compound *base words are missing: The list is database|codebase|firebase|knowledgebase. If your schema uses other compound base words (e.g. timebase, userbase), they'll need to be added here too.
  • Confirm bases → basis still works: The standalone word bases should still hit the ses$ rule and produce basis, since the expanded rule requires a compound prefix. Worth a quick SELECT inflection.singular('bases') after deploy.

Notes

  • Companion PRs: same fix in constructive-db (pgpm-inflection v0.15.5) and dev-utils/inflekt (JS side).
  • The enumerated word list approach matches the existing style. New compound *base words will need manual additions.

Link to Devin session: https://app.devin.ai/sessions/8ce3d5fe3c304df3bca72896972f083f
Requested by: @pyramation

@devin-ai-integration
Copy link
Copy Markdown

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@pyramation pyramation merged commit a37f225 into main Mar 30, 2026
22 checks passed
@pyramation pyramation deleted the devin/1774842759-fix-inflection-compound-base branch March 30, 2026 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant