feat: remove include_id from Data* modules and blueprint types#942
Open
pyramation wants to merge 1 commit intomainfrom
Open
feat: remove include_id from Data* modules and blueprint types#942pyramation wants to merge 1 commit intomainfrom
pyramation wants to merge 1 commit intomainfrom
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
include_idparameter from all 7 Data* module definitions that previously had it. Users must now explicitly includeDataIdas a separate node instead of relying on implicit primary key creation viainclude_id: true.Affected modules:
DataTimestamps,DataDirectOwner,DataSoftDelete,DataPublishable,DataPeoplestamps,DataEntityMembership,DataOwnershipInEntityFiles changed:
include_idfromparameter_schema.propertiesblueprint-types.generated.ts— removedinclude_id?: booleanfrom 7 param interfacesREADME.md— updated example to use string shorthand instead of{ $type: 'DataDirectOwner', data: { include_id: false } }Companion PR: constructive-db #722 removes
include_idfrom the SQL generators. These two PRs should be merged together.Review & Testing Checklist for Human
include_idusage — any existing blueprint definitions orsecure_table_provisionINSERTs that passinclude_idneed to be updated to use explicitDataIdinstead.sdk/still referenceinclude_idin comments (schema-types.ts, input-types.ts, public.graphql). These are generated from the DB schema and will be regenerated after constructive-db fix(codegen): use deepmerge for CLI config merging #722 is deployed — confirm this happens.Test plan: After merging both PRs, deploy and run
construct_blueprint()on a blueprint that usesDataId+DataTimestamps+DataDirectOwner(noinclude_id). Verify the table gets a UUID PK fromDataIdand that timestamps/ownership columns are created without errors.Notes
DataTimestampsParams,DataPublishableParams, andDataSoftDeleteParamsare now empty interfaces — these modules have no remaining configurable parameters.blueprint-types.generated.tswas edited manually rather than viapnpm generate:types. The edits are straightforward deletions but you may want to re-run the generator to confirm parity.Link to Devin session: https://app.devin.ai/sessions/094d88b562a04a2fa55dc2e4d85f7b8d
Requested by: @pyramation