Skip to content

Dev#269

Open
tkswanson wants to merge 88 commits into
mainfrom
dev
Open

Dev#269
tkswanson wants to merge 88 commits into
mainfrom
dev

Conversation

@tkswanson
Copy link
Copy Markdown
Member

No description provided.

tkswanson and others added 30 commits March 11, 2026 10:20
Fix for #247 collate function not handling broken images correctly
…ication_empty

change or to and and add else for empty not none check
add station and camera in bfm, add unittests
…nput_checks

add unit tests, check inputs for classification
…checks

add detection fnf handling and unittests
…omprehensive-unittest

Add unit tests for pipeline.py + fix broken export.py import
tkswanson and others added 21 commits April 20, 2026 12:19
…-for-visualization

Add unit tests for visualization.py
…files-visualization-unittest

Update tests to match current dev branch API
…e-for-export-functions

Add unit tests for animl/export.py
…r-distance-module

Add comprehensive unit tests for `animl/reid/`
@tkswanson tkswanson marked this pull request as ready for review April 24, 2026 18:28
@tkswanson tkswanson requested a review from matobler April 24, 2026 18:29
Copy link
Copy Markdown
Collaborator

@matobler matobler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a few minor comments.

Comment thread src/animl/utils/animlr.py Outdated
Comment thread src/animl/classification.py
Comment thread src/animl/detection.py
'frame': frame['frame'],
'max_detection_conf': frame['max_detection_conf'],
'category': 0, 'conf': None, 'bbox_x': None,
'category': None, 'conf': None, 'bbox_x': None,
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure this change from category 0 to category None won't break things. MD uses 0 as Empty. What is the reason for this chagne?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So that it can handle non-MD detectors correctly. I changed the way md is loaded and parsed to account for this change

Comment thread src/animl/file_management.py Outdated

def active_times(manifest_dir,
depth: int = 1,
camera_depth: int = 0,
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we get the camera name during bulid_manifest can we just use that? Give a camera columns with default being the one in generated?

Comment thread src/animl/file_management.py Outdated
timestamp_col (str): column in manifest to use for datetime information, defaults to "datetime"
recursive (bool): recursively search thhrough all child directories
offset (int): add timezone offset in hours to datetime column
data_timezone (str): timezone to apply to datetime column
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the new build_manifest timezone option the timezone shoudl be correct at this point.

Comment thread src/animl/file_management.py Outdated
files["filemodifydate"] = files["filepath"].apply(lambda x: datetime.fromtimestamp(Path(x).stat().st_mtime).strftime('%Y-%m-%d %H:%M:%S'))

files = manifest_dir
# from scratch
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need a "from scratch" option or can we just make users run build_file_manifest first?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants