fix: agent requestStart dedupe and stuck STARTING on daemon restart#580
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: Cursor <cursoragent@cursor.com>
Centralize process liveness probing in infrastructure/deps/process.ts and reuse in AgentProcessManager ensureRunning, recover, and stop paths. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Combined fix for stuck agent STARTING UI and phantom running slots after daemon restart. Supersedes closed PRs #575 and #577 (and incorporates backend dedupe from #559 approach).
dedupeRequestStartEvents—getCommandEventsreturns only the latestagent.requestStartperchatroomId:role(bytimestamp)ensureRunningverifiesrunningslots withkill(pid, 0); dead PIDs reset toidleand respawn instead of returning early successrecover()SIGTERM-kills alive persisted agents (-pid), recordsdaemon.shutdown, clears disk — never adopts asrunning(noupdateSpawnedAgent)Test plan
pnpm typecheckpnpm testCloses superseded: #575, #577
Made with Cursor