Open
Conversation
Contributor
Author
|
See PDAL/PDAL#4985 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces arbiter's use of the curl "easy" interface with the curl "multi" interface. This was recommended by the author of curl in order to reduce file descriptor use. Each easy "handle" would use at least three file descriptors to facilitate an http transfer. The multi interface uses a single descriptor for each transfer in addition to a couple of descriptors to facilitate asynchronous I/O. This should allow more transfers to occur without running out of file descriptors on system where they are a limited resource.
This change also does modifies the interface internally so that fetched data is moved rather than copied where possible.