Skip to content

fix: trim user-function error log; move full PollContext to DEBUG (fixes #640) #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vishal Kumar Singh (singhvishalkr) wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: trim user-function error log; move full PollContext to DEBUG (fixes #640) #919

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion .../main/java/io/confluent/parallelconsumer/internal/AbstractParallelEoSStreamProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1351,12 +1351,23 @@ protected <R> List<ParallelConsumer.Tuple<ConsumerRecord<K, V>, R>> runUserFunct
} catch (Exception e) {
// handle fail
var cause = e.getCause();
// Keep the primary error log line short (record count + partitions) so it stays readable
// when the user function throws for large batches; dumping the whole PollContext toString
// (which transitively prints every ConsumerRecord in the batch) tends to get truncated by
// downstream log tooling and can surface user-payload data inside error logs. The full
// context is still available at DEBUG for troubleshooting.
// See https://github.com/confluentinc/parallel-consumer/issues/640
long recordCount = context.getPollContext().size();
var partitions = context.getPollContext().getByTopicPartitionMap().keySet();
String msg = msg("Exception caught in user function running stage, registering WC as failed, returning to" +
" mailbox. Context: {}", context, e);
" mailbox. partitions={} records={}", partitions, recordCount);
if (cause instanceof PCRetriableException) {
log.debug("Explicit " + PCRetriableException.class.getSimpleName() + " caught, logging at DEBUG only. " + msg, e);
} else {
log.error(msg, e);
if (log.isDebugEnabled()) {
log.debug("Full PollContext for the failed user function batch: {}", context);
}
}

for (var wc : workContainerBatch) {
Expand Down