feat: support tax/shipping/discount lines in OrderResponse#84
Merged
Conversation
- Updated OrderResponse to include OrderShippingLinesResponse and OrderTaxLinesResponse. - Refactored discountLines and taxLines to use new response models. - Added new classes: OrderShippingLinesResponse, OrderTaxLinesResponse, ShippingLinesDataResponse, and TaxLinesDataResponse. - Modified OrdersApiTest to validate new shipping and tax lines in order responses.
|
…, and source files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OrderTaxLinesResponse,OrderShippingLinesResponse,OrderDiscountLinesResponse(and their*DataResponseitems) soOrderResponsedeserializes the list-object shape returned by the API fortax_lines,shipping_lines, anddiscount_lines.OrdersApiTestassertions to match the Mockoon fixture (mocks/conekta_api.json): replaces thecancelOrderTestProcessingExceptionworkaround with full success assertions, enrichescreateOrder/getOrderById/orderCancelRefundchecks, and removes thelimit=19+nextworkaround forgetOrders.Test plan
BASE_PATH=http://localhost:3000 mvn -B test -Dtest=OrdersApiTestagainst Mockoon fixture — 8/8 pass🤖 Generated with Claude Code