Skip to content

CODAP-179: right-align date-type attributes in case table#2348

Merged
bfinzer merged 2 commits intomainfrom
CODAP-179-date-right-align
Feb 5, 2026
Merged

CODAP-179: right-align date-type attributes in case table#2348
bfinzer merged 2 commits intomainfrom
CODAP-179-date-right-align

Conversation

@bfinzer
Copy link
Contributor

@bfinzer bfinzer commented Feb 5, 2026

Summary

  • Add numeric-format class to date cell content div so dates are right-aligned in the case table
  • Dates are now formatted and right-aligned when:
    1. The value is a standard ISO string (e.g., from date formulas)
    2. The user explicitly sets the attribute type to "date"
    3. The attribute values are all inferred to be dates

Fixes CODAP-179

Test plan

  • Open the Four Seals example document
  • Verify the date column values are right-aligned
  • Compare with CODAP v2 to confirm matching behavior
  • Test with an attribute where dates are inferred (not explicitly set as date type)

🤖 Generated with Claude Code

Add numeric-format class to date cell content div so dates are
right-aligned, matching CODAP v2 behavior.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@bfinzer bfinzer requested a review from kswenson February 5, 2026 18:43
@cypress
Copy link

cypress bot commented Feb 5, 2026

codap-v3    Run #9963

Run Properties:  status check passed Passed #9963  •  git commit d8d94481c4: Increment the build number
Project codap-v3
Branch Review main
Run status status check passed Passed #9963
Run duration 02m 04s
Commit git commit d8d94481c4: Increment the build number
Committer eireland
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.45%. Comparing base (2a1fbb4) to head (1edd222).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2348    +/-   ##
========================================
  Coverage   85.45%   85.45%            
========================================
  Files         746      746            
  Lines       40813    40814     +1     
  Branches     9636     9911   +275     
========================================
+ Hits        34875    34876     +1     
+ Misses       5929     5926     -3     
- Partials        9       12     +3     
Flag Coverage Δ
cypress 68.83% <100.00%> (+<0.01%) ⬆️
jest 56.72% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@kswenson kswenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@kswenson
Copy link
Member

kswenson commented Feb 5, 2026

  • Continuous Integration (CODAP v3) / Run Jest Tests (push)

Actually, there's a jest test failure that should be fixed before merge.

@kswenson kswenson requested a review from Copilot February 5, 2026 19:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds right-alignment for date-type attributes in the case table to match CODAP v2 behavior. The change applies the numeric-format CSS class to date cell content divs, ensuring consistent formatting with the legacy version.

Changes:

  • Added numeric-format class to date cell content div for right-alignment

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Add numeric-format class to date cell content div so dates are
right-aligned. Dates are now formatted and right-aligned when:
1. The value is a standard ISO string (e.g., from date formulas)
2. The user explicitly sets the attribute type to date
3. The attribute values are all inferred to be dates

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@bfinzer bfinzer merged commit 2ac65aa into main Feb 5, 2026
16 of 17 checks passed
@bfinzer bfinzer deleted the CODAP-179-date-right-align branch February 5, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants