CODAP-179: right-align date-type attributes in case table#2348
Conversation
Add numeric-format class to date cell content div so dates are right-aligned, matching CODAP v2 behavior. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
codap-v3
|
||||||||||||||||||||||||||||
| Project |
codap-v3
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 02m 04s |
| Commit |
|
| Committer | eireland |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
4
|
| View all changes introduced in this branch ↗︎ | |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2348 +/- ##
========================================
Coverage 85.45% 85.45%
========================================
Files 746 746
Lines 40813 40814 +1
Branches 9636 9911 +275
========================================
+ Hits 34875 34876 +1
+ Misses 5929 5926 -3
- Partials 9 12 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Actually, there's a jest test failure that should be fixed before merge. |
There was a problem hiding this comment.
Pull request overview
This PR adds right-alignment for date-type attributes in the case table to match CODAP v2 behavior. The change applies the numeric-format CSS class to date cell content divs, ensuring consistent formatting with the legacy version.
Changes:
- Added
numeric-formatclass to date cell content div for right-alignment
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add numeric-format class to date cell content div so dates are right-aligned. Dates are now formatted and right-aligned when: 1. The value is a standard ISO string (e.g., from date formulas) 2. The user explicitly sets the attribute type to date 3. The attribute values are all inferred to be dates Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Summary
numeric-formatclass to date cell content div so dates are right-aligned in the case tableFixes CODAP-179
Test plan
🤖 Generated with Claude Code