CODAP-1099: Fix point dragging in multi-y-attribute scatterplots#2334
Closed
CODAP-1099: Fix point dragging in multi-y-attribute scatterplots#2334
Conversation
Pass plotNum to getScreenY in refreshPointPositionsPerfMode so that points are positioned using their correct y-attribute values during drag operations, rather than always using the first y-attribute. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Member
|
Closing this PR as the fix is already in The change in this PR (commit c0e074b) is identical to commit 574866d which was merged to This PR: - const y = getScreenY(caseId)
+ const y = getScreenY(caseId, aCaseData.plotNum)Already in main (574866d): - const y = getScreenY(caseId)
+ const y = getScreenY(caseId, aCaseData.plotNum)Both fix the same issue where points in scatter plots with multiple Y attributes were collapsing to incorrect positions during drag operations because |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plotNumtogetScreenYinrefreshPointPositionsPerfModeso points use their correct y-attribute values during drag operationsDetails
When dragging points in performance mode (active during drag),
getScreenYwas called without theplotNumparameter, defaulting to 0. This caused all points to be positioned using the first y-attribute's values, making points from other y-attributes jump to incorrect positions at the start of a drag.Fixes CODAP-1099
Test plan