Skip to content

Acknowledge and confirm PR review status for enh-userwide-config#45

Closed
Copilot wants to merge 1 commit intoenh-userwide-configfrom
copilot/sub-pr-44
Closed

Acknowledge and confirm PR review status for enh-userwide-config#45
Copilot wants to merge 1 commit intoenh-userwide-configfrom
copilot/sub-pr-44

Conversation

Copy link
Contributor

Copilot AI commented Mar 1, 2026

Reviewer comments on PR #44 required a response to confirm which changes were intentional and which had already been addressed.

  • Comment 2 (eval/sed): Confirmed fixed in af66d08load_yolo_functions() sources bin/yolo directly via BASH_SOURCE guard, no more fragile eval/sed extraction.
  • Comment 3 (podman_args_contain): Confirmed intentional — bare function calls in BATS abort at the correct line on failure; run+assert_success wrapping only adds verbosity. Negative assertions handled by refute_podman_arg.
  • Comments 1 & 4 (tilde in full-form volumes, :Z on explicit options): Confirmed intentional — tests accurately document current expand_volume behavior; fixing these would be behavioral changes to bin/yolo, out of scope for this testing PR.
  • Comment 5 (integration-test || true): Confirmed non-issue — setup-yolo.sh exits 0 on user decline (exit 0 at line 259).

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Add user-wide configuration support and testing Acknowledge and confirm PR review status for enh-userwide-config Mar 1, 2026
@yarikoptic yarikoptic closed this Mar 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants