Refactor CLI for micro-sam backend support#1276
Open
anwai98 wants to merge 8 commits into
Open
Conversation
Collaborator
Author
|
Okay this is sorted now! @constantinpape Some details on how things would work:
|
constantinpape
left a comment
Contributor
There was a problem hiding this comment.
I will test this properly tomorrow morning. Noticed one minor thing that could be improved in the code review.
| return device | ||
|
|
||
|
|
||
| def get_embedding_function(model_type: str) -> callable: |
Contributor
There was a problem hiding this comment.
This doesn't raise an error for an invalid model_type. I think it's better to raise here if model_type is invalid rather than relying on v1.util.precompute_image_embeddings to raise later.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

WIP!