This repository was archived by the owner on Oct 30, 2025. It is now read-only.
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Closed
jetpham
added
priority: medium 🤔
type: design 🎨
Member
Author
|
comparison |
edwardshturman
suggested changes
Oct 23, 2024
Member
edwardshturman
left a comment
edwardshturman
left a comment
There was a problem hiding this comment.
i need some more convincing on why grid is accessibility--
| display: block; | ||
| } | ||
| } | ||
| } No newline at end of file |
Comment on lines
-90
to
-95
| ul > li::before { | ||
| position: absolute; | ||
| margin-left: -22px; | ||
| content: '>'; | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
In my opinion, removing list styles is an accessibility--, not ++
| margin-bottom: 80px; | ||
| } | ||
|
|
||
| section.innerSections { |
Member
There was a problem hiding this comment.
a new class name creates more boilerplate than necessary; can be replaced with section.details > section
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the background grid for clarity and accessabliity