Skip to content

fix: duplicate class attributes in combined card SVG #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
compscidr merged 1 commit into from
Mar 20, 2026
Merged

fix: duplicate class attributes in combined card SVG #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/cards/combined.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,10 +222,10 @@ const renderCombinedCard = (data, options = {}) => {
<path d="M 1.5 0.67 C 1.5 0.67 2.24 3.32 2.24 5.47 C 2.24 7.53 0.89 9.2 -1.17 9.2 C -3.23 9.2 -4.79 7.53 -4.79 5.47 L -4.76 5.11 C -6.78 7.51 -8 10.62 -8 13.99 C -8 18.41 -4.42 22 0 22 C 4.42 22 8 18.41 8 13.99 C 8 8.6 5.41 3.79 1.5 0.67 Z M -0.29 19 C -2.07 19 -3.51 17.6 -3.51 15.86 C -3.51 14.24 -2.46 13.1 -0.7 12.74 C 1.07 12.38 2.9 11.53 3.92 10.16 C 4.31 11.45 4.51 12.81 4.51 14.2 C 4.51 16.85 2.36 19 -0.29 19 Z" fill="${streakColor}" stroke-opacity="0" transform="scale(0.75)"/>
</g>
<!-- Current streak number -->
<text x="${streakCenterLeft}" y="52" text-anchor="middle" class="streak-number"
${disable_animations ? "" : `class="stagger" style="animation-delay: 1800ms"`}>${streak.currentStreak}</text>
<text x="${streakCenterLeft}" y="52" text-anchor="middle" class="streak-number${disable_animations ? "" : " stagger"}"
${disable_animations ? "" : `style="animation-delay: 1800ms"`}>${streak.currentStreak}</text>
<!-- Current streak label -->
<text x="${streakCenterLeft}" y="72" text-anchor="middle" class="streak-label-current"
<text x="${streakCenterLeft}" y="72" text-anchor="middle" class="streak-label-current${disable_animations ? "" : " stagger"}"
${disable_animations ? "" : `style="animation-delay: 1950ms"`}>Current Streak</text>
Comment on lines +228 to 229

Copilot AI Mar 20, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description says the duplicate class attribute fix only affects the streak number elements, but this hunk also adds the stagger class to the “Current Streak” label. If this is intentional (it makes the existing animation-delay effective), please update the PR description accordingly; otherwise revert the label change to keep the PR focused.

Copilot uses AI. Check for mistakes.
<!-- Current streak dates -->
<text x="${streakCenterLeft}" y="88" text-anchor="middle" class="streak-dates">${currentDates}</text>
Expand All @@ -234,8 +234,8 @@ const renderCombinedCard = (data, options = {}) => {
<line x1="${streakMid}" y1="8" x2="${streakMid}" y2="90" stroke="${borderColor}" stroke-width="1" opacity="0.5"/>

<!-- Longest streak number -->
<text x="${streakCenterRight}" y="40" text-anchor="middle" class="streak-number"
${disable_animations ? "" : `class="stagger" style="animation-delay: 2100ms"`}>${streak.longestStreak}</text>
<text x="${streakCenterRight}" y="40" text-anchor="middle" class="streak-number${disable_animations ? "" : " stagger"}"
${disable_animations ? "" : `style="animation-delay: 2100ms"`}>${streak.longestStreak}</text>
<!-- Longest streak label -->
<text x="${streakCenterRight}" y="60" text-anchor="middle" class="streak-label">Longest Streak</text>
<!-- Longest streak dates -->
Expand Down
Loading