erofs: Fix proptest check for compatibility with whiteouts#332
Open
cgwalters wants to merge 1 commit into
Open
erofs: Fix proptest check for compatibility with whiteouts#332cgwalters wants to merge 1 commit into
cgwalters wants to merge 1 commit into
Conversation
test_v1_binary_identical_to_c_mkcomposefs hardcoded FormatVersion::V0 when calling the Rust writer, but C mkcomposefs auto-bumps from version 0 to 1 when it encounters a whiteout (chardev rdev=0) in the input tree. When the random generator produced a CharacterDevice(0), the composefs_version header byte differed, causing a spurious failure. The companion test test_v1_binary_identical_unusual_content already handled this correctly. Extract the shared comparison logic into assert_binary_identical_to_c() so both tests use it. Assisted-by: opencode (claude-opus-4-6) Signed-off-by: Colin Walters <walters@verbum.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_v1_binary_identical_to_c_mkcomposefs hardcoded FormatVersion::V0 when calling the Rust writer, but C mkcomposefs auto-bumps from version 0 to 1 when it encounters a whiteout (chardev rdev=0) in the input tree. When the random generator produced a CharacterDevice(0), the composefs_version header byte differed, causing a spurious failure.
The companion test test_v1_binary_identical_unusual_content already handled this correctly. Extract the shared comparison logic into assert_binary_identical_to_c() so both tests use it.
Assisted-by: opencode (claude-opus-4-6)