Conversation
|
|
||
| ```jsx harmony | ||
| <ColorSwatch token={"accent"} value={"#C0100F"} /> | ||
| <ColorSwatch token={"accent"} aliases={"error"} value={"#C0100F"} /> |
There was a problem hiding this comment.
Let's create a separate example for aliases. Also the name suggests it should be an array but it's a string. I also don't see any propTypes definitions for that prop.
| import theme from "../theme"; | ||
|
|
||
| <Colors theme={theme} />; | ||
| <Colors theme={theme} aliasesKey={"aliases"} />; |
There was a problem hiding this comment.
Same here. Leave the basic example and add an advanced one where you explain why it's like this. I don't like the aliasesKey prop name TBH since it's not self explanatory.. Again, prop types are missing.
| palette.aliases = [ | ||
| "lightest", | ||
| "light", | ||
| "diabled", | ||
| "inactive", | ||
| "regular", | ||
| "hovered", | ||
| "errorLight", | ||
| ["error", "failure"], | ||
| "errorDark" | ||
| ]; | ||
|
|
||
| <PaletteSwatch token={"red"} value={palette} aliasesKey="aliases" />; |
There was a problem hiding this comment.
This example is overwhelming for me. Here is an example from the spec: https://styled-system.com/theme-specification#space which I'd suggest using.
| aliases: { | ||
| darker: "foused", | ||
| dark: "active", | ||
| base: "default", | ||
| light: "hovered", | ||
| lighter: "disabled", | ||
| lightest: "inactive" | ||
| } |
| ? items.map((value, index) => | ||
| children( | ||
| index, | ||
| value, | ||
| aliasesKey && items[aliasesKey] ? items[aliasesKey][index] : null | ||
| ) | ||
| ) | ||
| : Object.keys(items) | ||
| .filter(key => key !== aliasesKey) | ||
| .map(key => | ||
| children( | ||
| key, | ||
| items[key], | ||
| aliasesKey && items[aliasesKey] ? items[aliasesKey][key] : null | ||
| ) | ||
| )} |
There was a problem hiding this comment.
TBH I'm not sure I want to accept this code into the repo. Maybe the best course of action would be to do this in your repo after all. You can compose things with Swatches and Swatch, add the resolution logic on top of what'e being done and extend provided primitives.
Thoughts?
There was a problem hiding this comment.
Maybe we can just use this repo to create a custom library? The only component which can be reused without any change is Swatch (which gives copy-to-clipboard feature)
There was a problem hiding this comment.
I'm not sure yet. I'd like to support aliases but I'm not sure the code complexity is worth it. Is there a simpler way of getting aliases for tokens? Ideally, as the user, I should not care about providing alias keys to the library. Let me poke with it a bit and let you know.
2 participants
resolves #11