Conversation
conatus
changed the title
Tests verify the full-stack behaviour of the per-block card payment
override introduced in this PR:
1. PHP env script: page with allow_cards_override emits
STRIPE_DIRECT_DEBIT_ONLY: false; control page emits true.
No injectEnvOverrides — reads raw PHP output.
2. One-off tab enabled on the override page, disabled without it.
USE_STRIPE is injected; STRIPE_DIRECT_DEBIT_ONLY is left to
the real PHP output so the assertion is a genuine full-stack check.
3. /join body for a one-off donation on the override page contains
recurDonation=false, donationAmount>0, paymentMethod=creditCard.
setup.php creates the e2e-allow-cards-override-supporter seed page and
sets STRIPE_DIRECT_DEBIT_ONLY=true globally via carbon_set_theme_option
so that allow_cards_override has something observable to override.
conatus
commented
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
allow_cards_overridecheckbox to the CK Join Form block editor UI, which only appears when the global "Direct Debit Only" Stripe setting is enabledSTRIPE_DIRECT_DEBIT_ONLYtofalsein the environment JSON passed to the frontend, re-enabling card payments for that specific form instanceenv.test.tsconfirming the frontend correctly handlesSTRIPE_DIRECT_DEBIT_ONLY: falseTest plan
<script type="application/json" id="env">tag — confirmSTRIPE_DIRECT_DEBIT_ONLYisfalseSTRIPE_DIRECT_DEBIT_ONLYreverts totrueand card is hidden againyarn testinpackages/join-flow— confirm all 48 tests pass