Skip to content

Conversation

@anilkk
Copy link

@anilkk anilkk commented Apr 28, 2021

Summary

Description

Todo

  • Tests
    • Unit
    • Integration
    • Acceptance
  • Documentation
  • Type label for the PR

@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.64%. Comparing base (fbd673d) to head (f6c2aa2).
Report is 166 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1679   +/-   ##
=======================================
  Coverage   98.64%   98.64%           
=======================================
  Files         128      128           
  Lines        3385     3385           
  Branches      781      781           
=======================================
  Hits         3339     3339           
  Misses         42       42           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anilkk anilkk requested a review from stmeissner April 29, 2021 11:50
@stmeissner
Copy link
Contributor

@anilkk If the integration with the TypeScript SDK is the approach we highly recommend, I would go for #1681 right away and drop this. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants