Sync boot LUN before reset#129
Open
adeebshihadeh wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
qdl can leave a device unbootable if the GPT A/B metadata and UFS boot LUN disagree. The observed disk state was GPT marking
_bactive/bootable while the UFS boot LUN still pointed at LUN 1. ABL then fails before Linux:Fastboot avoids this through
SetActiveSlot(): even when the requested slot is already active, it checks the UFS boot LUN and rewrites it to match the slot (_a-> 1,_b-> 2). Normal qdl flash scripts do not callsetactiveslot; they flash and thenreset, so the mismatch survives.This syncs the UFS boot LUN from the detected active slot before
reset. If no A/B slot metadata is present, reset proceeds unchanged.Tested:
bun testbun run buildbun run lint_breset now sendssetbootablestoragedrive value=2; ABL logsBooting from slot (_b)instead of the mismatch error.