Open
Conversation
Replaces React entry point with a vanilla JS main file, adds new JS component and state management modules, and updates Vite and package configuration to remove React dependencies. Includes a detailed migration guide and updates the HTML entry point to use the new JS structure.
Replaces React entry point with a vanilla JS main file, adds new JS component and state management modules, and updates Vite and package configuration to remove React dependencies. Includes a detailed migration guide and updates the HTML entry point to use the new JS structure.
…arsheikh001/flash into sheasheikh/migration-to-html
Removed React-based test and main entrypoint files, replacing the test with a Vitest-based JavaScript test for AppComponent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces react with plain HTML.
Major Changes:
Framework and State Management:
Componentclass to serve as the foundation for vanilla JavaScript components, providing methods for rendering, state management, and event handling (src/js/components/base.js).StateManagerclass to manage application state and enable reactive updates across components (src/js/state.js).Flashing Tool Implementation:
FlashComponentto handle the device flashing process, including progress tracking, error handling, and platform-specific instructions (src/js/components/flash.js).CopyTextComponentto allow users to copy Linux-specific unbinding scripts for device preparation (src/js/components/app.js).Dependency and Build Updates:
react,react-dom,@types/react,@vitejs/plugin-react, etc.) frompackage.json.index.htmlto usemain.jsinstead ofmain.jsx.