Skip to content

Google-geocoder also works without a business account #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dmke wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Google-geocoder also works without a business account #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions lib/graticule/geocoder/google.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,21 @@ module Geocoder #:nodoc:
# p location.coordinates
# #=> [37.423111, -122.081783
#
# If don't have a Google business account, initialize with:
#
# gg = Graticule.service(:google).new(MAPS_API_KEY)
#
# If you have a Google business account, initialize with:
#
# gg = Graticule.service(:google).new(MAPS_API_KEY, MAPS_CLIENT_ID)
# gg = Graticule.service(:google).new(MAPS_PUBLIC_KEY, MAPS_CLIENT_ID)
#
class Google < Base
# https://developers.google.com/maps/documentation/geocoding/

def initialize(key=nil, client_id=nil)
@key = key
@client_id = client_id
@url = URI.parse 'http://maps.googleapis.com/maps/api/geocode/json'
@url = URI.parse 'https://maps.googleapis.com/maps/api/geocode/json'
end

# Locates +address+ returning a Location
Expand Down Expand Up @@ -45,7 +49,7 @@ def parse_address_components(components)
when "route"
@route = component["short_name"]
when "locality", "sublocality"
@locality = component["long_name"]
@locality = component["long_name"]
when "administrative_area_level_1"
@region = component["short_name"]
when "country"
Expand Down Expand Up @@ -139,11 +143,13 @@ def check_error(response) #:nodoc:
# the url as required by v3 of the library:
#
# https://developers.google.com/maps/documentation/business/webservices#digital_signatures
#
#
def make_url(params) #:nodoc:
if @key && @client_id
url = super params.merge(:sensor => false, :client => @client_id)
make_signed_url(url)
elsif @key
super params.merge(:sensor => false, :key => @key)
else
super params.merge(:sensor => false)
end
Expand Down