Skip to content

Support JSON serialization of document shapes (issue #270) #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scottbale merged 2 commits into from
Apr 7, 2026
Merged

Support JSON serialization of document shapes (issue #270) #309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d95853c
Support JSON serialization of document shapes (issue #270)
GaspardP May 6, 2025
e74bd8a
Merge branch 'main' into fix-270
scottbale Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/cognitect/aws/shape.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,11 @@

(defmethod json-serialize* "structure"
[shapes shape data]
(when data
(cond
(:document shape)
data

data
(reduce-kv (fn [m k v]
(if-let [member-shape (resolve shapes (structure-member-shape-ref shape k))]
(assoc m
Expand Down
6 changes: 6 additions & 0 deletions test/src/cognitect/aws/shape_test.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,9 @@
(shape/json-parse* {}
{:type "structure" :document true}
[{:this "is" :a "doc"}])))))

(deftest test-json-serialize
(is (= "{\"this\":\"is\",\"a\":\"doc\"}"
(shape/json-serialize {}
{:type "structure", :members {}, :document true}
{:this "is" :a "doc"}))))