Skip to content

Use official minio image for integration tests #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
scottbale wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Use official minio image for integration tests #289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2336863
Use official minio image for integration tests
scottbale Sep 30, 2025
4054925
args instead of options - Use official minio image for integration tests
scottbale Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,10 @@ jobs:

services:
s3:
image: bitnami/minio
image: minio/minio
ports:
- 9000:9000
args: ["server", "/data"]

steps:
- name: Checkout repository
Expand Down
4 changes: 2 additions & 2 deletions test/src/cognitect/aws/integration/s3_test.cljc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,8 @@
:hostname "localhost"
:port 9000}
:credentials-provider (creds/basic-credentials-provider
{:access-key-id "minio"
:secret-access-key "miniosecret"})})]
{:access-key-id "minioadmin"
:secret-access-key "minioadmin"})})]
(testing (str "with http client " (class %))
(test-s3-client s3)))))

Expand Down