Skip to content

Repo hardening: fix install instructions, dead imports, hygiene#1

Open
cognis-digital wants to merge 5 commits into
mainfrom
cognis-audit/repo-hardening
Open

Repo hardening: fix install instructions, dead imports, hygiene#1
cognis-digital wants to merge 5 commits into
mainfrom
cognis-audit/repo-hardening

Conversation

@cognis-digital

@cognis-digital cognis-digital commented Jun 12, 2026

Copy link
Copy Markdown
Owner

This PR applies a few small, mechanically-verified hardening fixes found by an automated audit of the Cognis suite:

  • fix 2 broken pip install line(s) in README (package is not on PyPI; use the working git+https install)
  • remove 4 unused import(s) (ruff F401/F811)

Each change is deterministic; all touched Python files were confirmed to still compile (py_compile) before this PR was opened.

- fix 2 broken `pip install` line(s) in README (package is not on PyPI; use the working git+https install)
- remove 4 unused import(s) (ruff F401/F811)

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first PR! 🚀 A maintainer will review under the collaboration-pull model (see CONTRIBUTING.md).

@cognis-digital cognis-digital force-pushed the cognis-audit/repo-hardening branch from 469ed29 to f498b83 Compare June 12, 2026 22:05
cognis-digital and others added 4 commits June 13, 2026 03:04
…-06-13)

- README install instructions point at the working git+https path
- ran the actual audit: 24 tests passed, 0 parse errors, CLI C:\Python314\python.exe: No module named https
- embedded results in README ## Verification and AUDIT.md
Inserts a What is this section in README.md with a non-technical
description of the tool, and adds a comprehensive Install section plus
cross-platform install.sh and install.ps1 scripts covering pipx, uv,
pip git+https, and source install. All 24 existing tests remain green.
- core.py: guard lat/lon outside WGS84 range and non-positive freq_mhz
  (coerce to None instead of passing garbage to analysis rules)
- core.py: clamp haversine intermediate value to [0,1] to prevent
  math.asin/math.sqrt raising on floating-point rounding at antipodes
- core.py: remove dead variable loiter_anchor (never read, F841)
- mcp_server.py: fix broken import of non-existent scan/to_json symbols;
  rewrite to use parse_log/analyze/json.dumps with ParseError handling
- cli.py: catch UnicodeDecodeError when reading binary/non-UTF-8 files
  and surface it as a clean exit-2 message rather than a raw traceback
- tests: 9 new edge-case tests covering the above paths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant