Repo hardening: fix install instructions, dead imports, hygiene#1
Open
cognis-digital wants to merge 5 commits into
Open
Repo hardening: fix install instructions, dead imports, hygiene#1cognis-digital wants to merge 5 commits into
cognis-digital wants to merge 5 commits into
Conversation
- fix 2 broken `pip install` line(s) in README (package is not on PyPI; use the working git+https install) - remove 4 unused import(s) (ruff F401/F811)
469ed29 to
f498b83
Compare
…-06-13) - README install instructions point at the working git+https path - ran the actual audit: 24 tests passed, 0 parse errors, CLI C:\Python314\python.exe: No module named https - embedded results in README ## Verification and AUDIT.md
Inserts a What is this section in README.md with a non-technical description of the tool, and adds a comprehensive Install section plus cross-platform install.sh and install.ps1 scripts covering pipx, uv, pip git+https, and source install. All 24 existing tests remain green.
- core.py: guard lat/lon outside WGS84 range and non-positive freq_mhz (coerce to None instead of passing garbage to analysis rules) - core.py: clamp haversine intermediate value to [0,1] to prevent math.asin/math.sqrt raising on floating-point rounding at antipodes - core.py: remove dead variable loiter_anchor (never read, F841) - mcp_server.py: fix broken import of non-existent scan/to_json symbols; rewrite to use parse_log/analyze/json.dumps with ParseError handling - cli.py: catch UnicodeDecodeError when reading binary/non-UTF-8 files and surface it as a clean exit-2 message rather than a raw traceback - tests: 9 new edge-case tests covering the above paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies a few small, mechanically-verified hardening fixes found by an automated audit of the Cognis suite:
pip installline(s) in README (package is not on PyPI; use the working git+https install)Each change is deterministic; all touched Python files were confirmed to still compile (
py_compile) before this PR was opened.