Repo hardening: fix install instructions, dead imports, hygiene#1
Open
cognis-digital wants to merge 4 commits into
Open
Repo hardening: fix install instructions, dead imports, hygiene#1cognis-digital wants to merge 4 commits into
cognis-digital wants to merge 4 commits into
Conversation
- fix 1 broken `pip install` line(s) in README (package is not on PyPI; use the working git+https install) - remove 4 unused import(s) (ruff F401/F811)
12c1857 to
c57eb8e
Compare
added 3 commits
June 13, 2026 08:10
…ge overview and install instructions The demo corpus flood-* documents all had identical embeddings, which compressed the MAD to near-zero and caused kb-2 (a clean document) to be flagged as a norm outlier (robust z = -4.0). Fixed by giving each flood-* document a slightly different embedding while keeping the texts identical — the duplication detector still catches the flooding attack, and clean kb-* documents now pass the embedding anomaly detector without false positives. Also added a plain-language "What is this?" section and comprehensive install scripts (install.sh + install.ps1) via the enrich pipeline.
- core.load_jsonl: guard IsADirectoryError before open(); improve non-dict error message with actual type name - core.scan_corpus: validate docs is a list (TypeError) and dup_threshold is a float in (0.0, 1.0] (ValueError) before running any detectors - cli.main: validate --dup-threshold range (exit 2 with message); catch IsADirectoryError, PermissionError, OSError from load_jsonl and wrap scan_corpus errors — no raw traceback on bad input; fix getattr guard so no-command path is robust - integrations/webhook.py: validate URL scheme (http/https only); validate --timeout > 0; reject empty or non-JSON stdin; validate header format (Key: Value); distinguish HTTPError/URLError/OSError - tests/test_hardening.py: 24 new tests covering missing file (exit 2), directory path (exit 2), out-of-range threshold (exit 2), malformed JSONL (exit 2), empty corpus, non-list docs, None/missing text fields, non-numeric embeddings, and all-zero severity counts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies a few small, mechanically-verified hardening fixes found by an automated audit of the Cognis suite:
pip installline(s) in README (package is not on PyPI; use the working git+https install)Each change is deterministic; all touched Python files were confirmed to still compile (
py_compile) before this PR was opened.