Repo hardening: fix install instructions, dead imports, hygiene#2
Open
cognis-digital wants to merge 4 commits into
Open
Repo hardening: fix install instructions, dead imports, hygiene#2cognis-digital wants to merge 4 commits into
cognis-digital wants to merge 4 commits into
Conversation
- fix 2 broken `pip install` line(s) in README (package is not on PyPI; use the working git+https install) - remove 5 unused import(s) (ruff F401/F811)
7cf9ed0 to
018de55
Compare
added 3 commits
June 13, 2026 07:57
- Add layman.md with a non-technical description of what otaverify does - Insert "What is this?" section into README explaining the tool to a general audience - Add comprehensive Install section to README before existing quick-start content - Write install.sh (POSIX) and install.ps1 (Windows) covering pipx/uv/pip/source install paths
- core.py: load_json raises ValueError with clear message on malformed JSON, non-dict root, or empty path; _hmac_hex handles non-string keys; verify_manifest guards against non-list signatures and non-dict sig entries; verify_package normalises payloads to dict safely - mcp_server.py: fix broken scan/to_json imports (used non-existent functions); wire to load_json + verify_package with error wrapping - integrations/webhook.py: fix ruff E401; validate URL scheme and non-empty stdin before POSTing; skip malformed --header entries - tests/test_hardening.py: 20 new tests covering missing file (exit 2), malformed JSON (exit 2), JSON array (exit 2), no subcommand (exit 2), non-list/None signatures, non-dict sig entry, non-dict payloads, _hmac_hex with plain-text and non-string keys, empty package
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies a few small, mechanically-verified hardening fixes found by an automated audit of the Cognis suite:
pip installline(s) in README (package is not on PyPI; use the working git+https install)Each change is deterministic; all touched Python files were confirmed to still compile (
py_compile) before this PR was opened.