Skip to content

Repo hardening: fix install instructions, dead imports, hygiene#2

Open
cognis-digital wants to merge 4 commits into
mainfrom
cognis-audit/repo-hardening
Open

Repo hardening: fix install instructions, dead imports, hygiene#2
cognis-digital wants to merge 4 commits into
mainfrom
cognis-audit/repo-hardening

Conversation

@cognis-digital

@cognis-digital cognis-digital commented Jun 12, 2026

Copy link
Copy Markdown
Owner

This PR applies a few small, mechanically-verified hardening fixes found by an automated audit of the Cognis suite:

  • fix 2 broken pip install line(s) in README (package is not on PyPI; use the working git+https install)
  • remove 5 unused import(s) (ruff F401/F811)

Each change is deterministic; all touched Python files were confirmed to still compile (py_compile) before this PR was opened.

- fix 2 broken `pip install` line(s) in README (package is not on PyPI; use the working git+https install)
- remove 5 unused import(s) (ruff F401/F811)
@cognis-digital cognis-digital force-pushed the cognis-audit/repo-hardening branch from 7cf9ed0 to 018de55 Compare June 12, 2026 21:58
Cognis Digital added 3 commits June 13, 2026 07:57
- Add layman.md with a non-technical description of what otaverify does
- Insert "What is this?" section into README explaining the tool to a general audience
- Add comprehensive Install section to README before existing quick-start content
- Write install.sh (POSIX) and install.ps1 (Windows) covering pipx/uv/pip/source install paths
- core.py: load_json raises ValueError with clear message on malformed
  JSON, non-dict root, or empty path; _hmac_hex handles non-string keys;
  verify_manifest guards against non-list signatures and non-dict sig
  entries; verify_package normalises payloads to dict safely
- mcp_server.py: fix broken scan/to_json imports (used non-existent
  functions); wire to load_json + verify_package with error wrapping
- integrations/webhook.py: fix ruff E401; validate URL scheme and
  non-empty stdin before POSTing; skip malformed --header entries
- tests/test_hardening.py: 20 new tests covering missing file (exit 2),
  malformed JSON (exit 2), JSON array (exit 2), no subcommand (exit 2),
  non-list/None signatures, non-dict sig entry, non-dict payloads,
  _hmac_hex with plain-text and non-string keys, empty package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant