Repo hardening: fix install instructions, dead imports, hygiene#1
Open
cognis-digital wants to merge 3 commits into
Open
Repo hardening: fix install instructions, dead imports, hygiene#1cognis-digital wants to merge 3 commits into
cognis-digital wants to merge 3 commits into
Conversation
- fix 2 broken `pip install` line(s) in README (package is not on PyPI; use the working git+https install) - remove 3 unused import(s) (ruff F401/F811)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
cognis-digital
force-pushed
the
cognis-audit/repo-hardening
branch
from
75cfb11 to
d7bddf4
Compare
added 2 commits
June 13, 2026 04:16
…e overview and install instructions
The CLI's --format option was only registered on the top-level parser,
so passing it after the 'analyze' subcommand ('analyze <file> --format json')
caused argparse to reject it with 'unrecognized arguments'. Added --format to
the analyze subparser (with None default so the top-level value still acts as
fallback) and updated _cmd_analyze to merge both levels. All 13 tests now pass.
Also inserted a plain-language "What is this?" section into README.md,
refreshed install.sh, and added install.ps1 for Windows users.
- cli.py: validate --port in range 1-65535, exit 2 with clear message - cli.py: add per-connection recv timeout (30s) to prevent hanging on stalled/hostile clients; guard MBAP struct.unpack in serve loop - cli.py: cap MBAP body read to 260 bytes to block memory-exhaustion via oversized length field - cli.py: catch UnicodeDecodeError from binary files passed as hexlog, surface as clean error/exit 2 instead of raw traceback - core.py: cap build_response coil/register quantities at Modbus spec maximums so byte-count field never overflows (was crashing on qty>2040) - mcp_server.py: fix dead imports (scan/to_json do not exist); wire to analyze_capture instead; guard empty hexlog input - tests/test_hardening.py: 10 new tests covering missing file, binary file, empty input, oversized quantity, out-of-range port, no subcommand
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies a few small, mechanically-verified hardening fixes found by an automated audit of the Cognis suite:
pip installline(s) in README (package is not on PyPI; use the working git+https install)Each change is deterministic; all touched Python files were confirmed to still compile (
py_compile) before this PR was opened.