Repo hardening: fix install instructions, dead imports, hygiene#2
Open
cognis-digital wants to merge 3 commits into
Open
Repo hardening: fix install instructions, dead imports, hygiene#2cognis-digital wants to merge 3 commits into
cognis-digital wants to merge 3 commits into
Conversation
ff04fa5 to
23eefd8
Compare
…rehensive cross-platform install scripts - README opens with a plain-language "What is this?" overview - comprehensive Install section + install.sh / install.ps1 (pipx / uv / pip git+https / source) - verified build-out: real test + CLI audit embedded (README Verification + AUDIT.md)
2a97d39 to
4609aab
Compare
added 2 commits
June 13, 2026 09:18
- scan() now raises FileNotFoundError for missing targets so the CLI
surfaces a clear message (exit 2) instead of a raw traceback
- parse_osquery_results guards against missing files, empty files,
malformed JSON, and unexpected shapes — returns {_error} dict each time
- scan() skips non-list query values silently rather than crashing
- emit_query_pack encodes output files with explicit utf-8
- make_cli wraps scan_fn calls in FileNotFoundError / ValueError /
Exception handlers with clean stderr messages and non-zero exit codes
- make_cli uses open(..., encoding='utf-8') when writing --out files and
wraps that in OSError handling
- Fix all ruff F/E violations across cognis_mil and comint_osquery
(F401 re-export aliases, E401/E701/E702/E722/F541)
- Add tests/test_hardening.py: 10 tests covering missing file, empty file,
malformed JSON, unexpected JSON shape, missing target dir,
malformed-file finding, empty dir scan, non-list rows, file write, no-out
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies a few small, mechanically-verified hardening fixes found by an automated audit of the Cognis suite:
pip installline(s) in README (package is not on PyPI; use the working git+https install)Each change is deterministic; all touched Python files were confirmed to still compile (
py_compile) before this PR was opened.