Repo hardening: fix install instructions, dead imports, hygiene#1
Open
cognis-digital wants to merge 5 commits into
Open
Repo hardening: fix install instructions, dead imports, hygiene#1cognis-digital wants to merge 5 commits into
cognis-digital wants to merge 5 commits into
Conversation
- fix 2 broken `pip install` line(s) in README (package is not on PyPI; use the working git+https install) - remove 5 unused import(s) (ruff F401/F811)
95d06af to
e688148
Compare
…-06-13) - README install instructions point at the working git+https path - ran the actual audit: 13 tests passed, 0 parse errors, CLI C:\Python314\python.exe: No module named https - embedded results in README ## Verification and AUDIT.md
- Insert "What is this?" section in README with non-technical description of the tool - Add/refresh cross-platform Install section in README (pipx/uv/pip/source) - Write install.sh (Linux/macOS) and install.ps1 (Windows) one-liner installers - Add layman.md source file for the plain-language description
- core.py: guard parse_observations against None input; fix TypeError bug in build_graph when the same downstream source appears with duplicate explicit via observations (datetime vs float comparison in explicit dict) - core.py: deduplicate explicit edges so each downstream source gets at most one explicit inbound edge - cli.py: catch PermissionError, IsADirectoryError, and generic OSError from file reads; reject empty / whitespace-only stdin with a clear error - integrations/webhook.py: split compound import (ruff E401); validate URL scheme; reject empty payload before attempting POST - tests/test_hardening.py: 19 new tests covering all new error/edge paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies a few small, mechanically-verified hardening fixes found by an automated audit of the Cognis suite:
pip installline(s) in README (package is not on PyPI; use the working git+https install)Each change is deterministic; all touched Python files were confirmed to still compile (
py_compile) before this PR was opened.