Skip to content

Fluent UI#184

Open
gabriel-vanca wants to merge 36 commits intocoenm:mainfrom
gabriel-vanca:Fluent_UI
Open

Fluent UI#184
gabriel-vanca wants to merge 36 commits intocoenm:mainfrom
gabriel-vanca:Fluent_UI

Conversation

@gabriel-vanca
Copy link
Contributor

@gabriel-vanca gabriel-vanca commented Sep 20, 2024

Decided to rethink PR #162 and switch to Fluent design as Material looks outdated, MahApps Metro is very slow in getting updates and FluentWpf has not been maintained for 3 years.

PR changelog:

  1. Deprecates MahApps Metro and FluentWpf . Switches to WpfUI (https://github.com/lepoco/wpfui)
  2. Deprecates Windows.Forms. Switches fully to Wpf.
  3. Deprecates Material and Metro theme components. Switches fully to Fluent design.
  4. Deprecates out-of-date controls (AcrylicContextMenu, AcrylicMenuItem, ZtextBox, Acrylic Helper, Windows Composition helper)
  5. Deprecates old icon system. Switches the the Windows native Segoe MDL2
  6. Deprecates Consolas typeface. Changes to Adobe Source Code Pro (https://github.com/adobe-fonts/source-code-pro)
  7. Adobe Source Code Pro is now embedded in the project.
  8. App now supports Dark Mode, Light Mode and High Constrast Mode (depending on Windows configuration)
  9. App will dynamically change its theme if Windows changes its theme.
  10. Simplifies the global hotkey logic.
  11. Simplifies the MainWindow hotkey logic,
  12. Simplifies the Taskbar management system (lots of old code remaining from RepoZ and its MacOS support now removed)
  13. Fixes the stay active window (activate by pressing F12) -> now the window can stay active once it loses focus. Closes Sticky Window (F12) #190 .
  14. Fixes some XAML bugs

Dark Mode:

image

Light Mode:

image

image

High Contrast Mode: (dark high contrast modes are coming later)

image

Ideas for future PRs:

  1. Theme is not saved to settings as of now.
  2. Still no option to change theme manually.
  3. Option to change the hotkey from settings.
  4. Clicking the Pin icon should unpin repositories
  5. Pinned repositories should be saved between sessions

@gabriel-vanca
Copy link
Contributor Author

gabriel-vanca commented Sep 20, 2024

@coenm , Apologies for putting so much in one PR. Replacing some UI things required replacing others and that broke other things, so it kind of required re-writing much of the MainWindow logic. And sorry about the large number of files; they're mostly fonts, themes and colour palettes.

@gabriel-vanca
Copy link
Contributor Author

Hi @coenm , let me know if you're still considering this PR as I had a few more UI-related ideas that depend on this PR.

@coenm
Copy link
Owner

coenm commented Nov 25, 2024

Hi @coenm , let me know if you're still considering this PR as I had a few more UI-related ideas that depend on this PR.

Hi @gabriel-vanca ,

Yes, I'm still open for an UI update. However, I liked your dark mode in PR #162 more compared to this one. Also, both PR's had some 'issues' or additions I didn't like and were blocking for me.

If you are still willing to put some time into RepoM (which i'm really grateful for), we should come up with some plan first before you putting in all this effort.

@gabriel-vanca
Copy link
Contributor Author

Sure, @coenm , I'd like that. The UI framework in the previous PR is deprecated, so I suggest we should use this newer one. The theme can be changed easily to be closer to the theme in the old one.

What do you have in mind regarding blocking additions and changes?

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sticky Window (F12)

2 participants