Update Default Configs by gabriel-vanca · Pull Request #175 · coenm/RepoM

gabriel-vanca · 2024-09-10T05:29:00Z

This PR does the following:

Updates the default Ordering config. It now defaults to Private (renamed to "Most Active" so as to differentiate it from Tags that are similarly named)
Changes the default filtering system name to All. The Private filter is changed to only include repos marked as private.
Fixes the bug in No repository is displayed #145 where the app would default to the first filter found, not to the filter marked as Default.
The name "All" is made a reserved filter name.
Filters named "Default" will overwrite the "All" setting.
_queryDictionary was, in fact, a List. No more :)
Eliminates redundant List<T>.Contains() checks.
Fixes the fork display problem ( browse-repository@1 useless with forks #170 )
Fixes the pin crash ( - type: pin-repository@1 crashes repo menu #169 ) (and possibly Enums in RepositoryActions #87 ?)
Partially fixes the default installation issue ( Update default values after installation to make sense #156 , and brought up in Howto add context menu item 'Explore Remote Repository'? #151 ). Still think it would be ideal to set them at install or at least at startup so that the app doesn't waste any time whatsoever unnecessarily checking if they're installed every time.
Updates Logger and YAML parser
Other code simplifications.
Improves the overall UI and adds icons

This should be unnecessary after this update.

gabriel-vanca · 2024-09-10T16:16:32Z

Later Edit: Some quick updates so that the fix to #170 is not limited just to GitHub

gabriel-vanca · 2024-09-10T16:48:11Z

Tests seem be failing due to the name changes of fields in the Action Menu, but not entirely sure why.

gabriel-vanca · 2024-09-14T20:03:03Z

Update: Fixed an error related to #177 .
Recommending that #178 is merged before this PR.

coenm · 2024-09-14T21:57:07Z

Hi, Thanks for your PR and for all the time you put into RepoM. I appreciate it.

However, it's hard for me to review your PR as you are solving quite a number of issues. I prefer smaller PR trying to solve one issue at the time.

Because you put in so much effort, I'm going to write my feedback in different files right now.

coenm

You did a lot, and again, thanks for that.
I hope you don't take this the wrong way but most of the changes are not necessary and take a lot time to review.

I thinks it better to discuss solutions, fixes or style changes upfront. Also make separate PRs if you address multiple issues.

Again, thanks for all the effort. I really hope you take the comments not personal.

coenm · 2024-09-14T21:58:30Z

...re/ActionMenu/Model/ActionMenus/BrowseRepository/RepositoryActionBrowseRepositoryV1Mapper.cs

        if (repository.Remotes.Count == 1 || forceSingle)
        {
-            yield return new UserInterfaceRepositoryAction(name, repository)
+            menuTitle = "🔗 " + try_get_remote_repo_long_name(repository.Remotes[0].Url);


I really like the icons in the menu using RepositoryActionsV2.yaml configuration but not in the c# code.

...re/ActionMenu/Model/ActionMenus/BrowseRepository/RepositoryActionBrowseRepositoryV1Mapper.cs

coenm · 2024-09-14T22:00:13Z

...re/ActionMenu/Model/ActionMenus/BrowseRepository/RepositoryActionBrowseRepositoryV1Mapper.cs

-            name = "Browse remote";
-        }
+        string menuTitle;
+        //var menuTitle = await context.RenderStringAsync(action.Name).ConfigureAwait(false);


not sure why this is commented

It's no longer gettng that text that way. It's getting it in a different way, depending on whether there is one or more remotes. See lines 32-52.

coenm · 2024-09-14T22:01:40Z

...re/ActionMenu/Model/ActionMenus/BrowseRepository/RepositoryActionBrowseRepositoryV1Mapper.cs

        }
    }

+    private static string try_get_remote_repo_long_name(string remoteUrl)


I like that you are trying to solve/generate a remote name but i'm not sure this is the method I want

...M.ActionMenu.Core/ActionMenu/Model/ActionMenus/Git/Checkout/RepositoryActionGitCheckoutV1.cs

src/RepoM.Plugin.AzureDevOps/AzureDevOpsModule.cs

src/RepoM.Plugin.AzureDevOps/Internal/PullRequest.cs

src/RepoM.Plugin.Clipboard/RepositoryAction/CopyToClipboardRepositoryCommandExecutor.cs

src/RepoM.Plugin.Statistics/StatisticsModule.cs

tests/RepoM.Plugin.Heidi.Tests/EnvironmentVariableManager.cs

gabriel-vanca · 2024-09-20T03:21:56Z

You did a lot, and again, thanks for that. I hope you don't take this the wrong way but most of the changes are not necessary and take a lot time to review.

I thinks it better to discuss solutions, fixes or style changes upfront. Also make separate PRs if you address multiple issues.

Again, thanks for all the effort. I really hope you take the comments not personal.

Sure, no worries. I'll break it down in more PRs in the future.
Sorry for the long delay. All should be fixed now.

sonarqubecloud · 2026-02-12T19:07:40Z

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

gabriel-vanca added 12 commits September 10, 2024 02:08

Update YAML

d987487

Simplify code

8174e26

Update logger

ac36015

Update Default order mechanism

3269350

Update the hamburger menu options and added checks

d9cb8c4

Updates default filtering config

219bccb

Changed name of default order scheme

155cb9d

Changes default filtering to All and updates Private

df9ca17

improve filtering mechanism

2e2a46c

Fixes the fork problem + code cleanup

271292a

Fixes pin problem

365a25c

Setting the mode

6375a50

This should be unnecessary after this update.

gabriel-vanca force-pushed the order branch from 5a848e5 to 6375a50 Compare September 10, 2024 05:42

gabriel-vanca added 2 commits September 10, 2024 06:59

More icons

a8c180d

Update so that it is not limited to GitHub

a0bd9e6

fixes

577a843

fixed error

f9f8b99

coenm reviewed Sep 14, 2024

View reviewed changes

restore style and YAML package

e8ae97b

Conversation

gabriel-vanca commented Sep 10, 2024

Uh oh!

gabriel-vanca commented Sep 10, 2024

Uh oh!

gabriel-vanca commented Sep 10, 2024

Uh oh!

gabriel-vanca commented Sep 14, 2024

Uh oh!

coenm commented Sep 14, 2024

Uh oh!

coenm left a comment

Choose a reason for hiding this comment

Uh oh!

coenm Sep 14, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coenm Sep 14, 2024

Choose a reason for hiding this comment

Uh oh!

gabriel-vanca Sep 20, 2024

Choose a reason for hiding this comment

Uh oh!

coenm Sep 14, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gabriel-vanca commented Sep 20, 2024

Uh oh!

sonarqubecloud bot commented Feb 12, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants