Notification Rule Processing Engine

[zaibkhan]

Mirrors ai-code-review-evaluation#5 for like-for-like benchmarking.

• Base: notification-rule-baseline
• Head: notification-rule-enhancements

Original PR excerpt:

Test 5

[codoki-pr-intelligence]

Codoki PR Review

Summary: URL-encode UID in link, prevent malformed paths
What’s good: Solid branching between alerting/recording/unknown rules with careful optional chaining; type additions for provenance align with usage.
Review Status: ❌ Requires changes
Overall Priority: Critical
Review Update:
• Coverage: Reviewed all 14 files across 2 batches

Issues (Critical & High only)

Severity	Issue	Why it matters
Critical	Correctness — Undefined 'ctx' in permission checks causes build failure	…/hooks/useAbilities.ts ctx is not defined in this scope, which will cause a compile-time error and break the build; use the existing access control service (e.g., contextSrv) or a dedicated hook to check folder permissions for Grafana-managed rules. Replace both permission checks to avoid runtime failures.

Showing top 1 issues. Critical: 1, High: 0. See inline suggestions for more.

Key Feedback (click to expand)

• Needs improvement: - Encode dynamic path segments to avoid edge-case breakage when UIDs contain special characters.
• Consider reusing the new isProvisionedPromRule() helper to keep provisioned checks consistent across the codebase.
• Testing: Add a UI/unit test ensuring the generated href properly encodes UIDs containing characters like spaces or slashes.
• Open questions: Are rule UIDs guaranteed to be strictly URL-safe (alphanumeric/ULID)? If not, encoding is needed to avoid broken links.

Confidence: 2/5 — Not ready to merge (1 critical · status: Requires changes)

React with 👍 or 👎 if you found this review useful.

[codoki-pr-intelligence]

🛑 Critical: ctx is not defined in this scope, which will cause a compile-time error and break the build; use the existing access control service (e.g., contextSrv) or a dedicated hook to check folder permissions for Grafana-managed rules. Replace both permission checks to avoid runtime failures.

Suggested change

	import { contextSrv } from 'app/core/core';
	const canEditGrafanaRules = contextSrv.hasPermissionInMetadata(rulesPermissions.update, folder);
	const canRemoveGrafanaRules = contextSrv.hasPermissionInMetadata(rulesPermissions.delete, folder);

[codoki-pr-intelligence]

🔷 Medium: UID is interpolated into the path without URL encoding; if a UID contains reserved characters, the link can break or route incorrectly. Encode the segment to ensure a valid, safe URL.

Suggested change

	href: createRelativeUrl(`/alerting/grafana/${uid}/view`),
	```suggestion
	href: createRelativeUrl(`/alerting/grafana/${encodeURIComponent(uid)}/view`),