Skip to content

feat: New field in Note's schema#284

Merged
TheGeniusOfEternity merged 3 commits intomainfrom
creator_id-property-add
Feb 5, 2025
Merged

feat: New field in Note's schema#284
TheGeniusOfEternity merged 3 commits intomainfrom
creator_id-property-add

Conversation

@TheGeniusOfEternity
Copy link
Contributor

Now you can send creatorId field from database to use it in frontend. This solves #283.

Now you can send creatorId field from  database to use it in frontend
@github-actions
Copy link

github-actions bot commented Jan 14, 2025

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 85.94% (🎯 80%)
⬆️ +0.01%
8572 / 9974
🟢 Statements 85.94% (🎯 80%)
⬆️ +0.01%
8572 / 9974
🔴 Functions 79.22% (🎯 80%)
🟰 ±0%
267 / 337
🟢 Branches 85.4% (🎯 80%)
🟰 ±0%
427 / 500
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/presentation/http/schema/Note.ts 100%
🟰 ±0%
100%
🟰 ±0%
100%
🟰 ±0%
100%
🟰 ±0%
Generated in workflow #869 for commit 9c14c3c by the Vitest Coverage Report Action

Copy link
Member

@neSpecc neSpecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add this field to the note test, please

Now we are waiting for creatorId field from notes api
Tiny fix in GET note/:notePublicId test
@TheGeniusOfEternity TheGeniusOfEternity merged commit a703367 into main Feb 5, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants