Closed
Conversation
lenzai
reviewed
Dec 27, 2017
Member
lenzai
left a comment
lenzai
left a comment
There was a problem hiding this comment.
- a lot of changes off topic. Lack of discipline.
- a lot of redundant noise in the diff. This is a bad habbit.
- hiding loadDatabase is questionable, making the behaviour smarter and obscure. Making calls to search database .
- it seems that addSimilarItems is broken. It should embrace the same style as searchDatabase with a callback.
Overall: a lot of noise and distraction , the main change is mostly different, not really better.
lenzai
reviewed
Dec 27, 2017
Member
lenzai
left a comment
lenzai
left a comment
There was a problem hiding this comment.
are the changes in app.js part of the fix? Or just a distraction?
lenzai
reviewed
Dec 27, 2017
Member
lenzai
left a comment
lenzai
left a comment
There was a problem hiding this comment.
Clearly this features is screaming for OOP
Here are the symptoms
- adding global variables
- adding extra arguments to functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Big refactoring, changing code structure and merging it with the new features introduced in logDouble branch: #53