fix: preserve escaped pipes in nexus page table cells#61
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes the Nexus-page BBCode generator’s Markdown pipe-table parsing so escaped pipes (\|) inside table cells don’t incorrectly split the row into extra cells. This ensures tables in the README “nexus” block convert reliably to BBCode when cell content includes literal pipe characters.
Changes:
- Update the table row splitting logic to split only on unescaped
|characters usingre.split(r"(?<!\\)\|", ...). - Unescape
\|to|within each parsed cell before inline Markdown→BBCode conversion.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Markdown pipe-table parser in
scripts/generate-nexus-page.pysplit each row on every|, so a cell containing an escaped pipe (\|) was incorrectly fractured into multiple cells.Split on unescaped pipes only (
re.split(r"(?<!\\)\|", ...)) and unescape\|→|within each cell.Verified against a table containing escaped pipes; the real README still generates identical output.
Mirrors the same fix applied upstream in the CommonLibSSE-NG-template.