Skip to content

chore: document TrimWhitespace string_view lifetime requirement #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codepuncher merged 1 commit into from
Jun 20, 2026
Merged

chore: document TrimWhitespace string_view lifetime requirement #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Utils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
namespace HoldFast
{

// Returns a view into `s`, so the caller must keep that buffer alive for as long
// as the returned view is used (do not pass a temporary std::string).
[[nodiscard]] inline std::string_view TrimWhitespace(std::string_view s)
{
const auto first = s.find_first_not_of(" \t\r\n");
Expand Down
Loading