Skip to content

feat(ui): restructure SMF menu layout with section headers and spacing#58

Merged
codepuncher merged 1 commit into
mainfrom
feat/smf-menu-layout-redesign
Jun 18, 2026
Merged

feat(ui): restructure SMF menu layout with section headers and spacing#58
codepuncher merged 1 commit into
mainfrom
feat/smf-menu-layout-redesign

Conversation

@codepuncher

Copy link
Copy Markdown
Owner

Summary

  • Adds SeparatorText headers (General, Start button, Back button) to divide the flat settings list into named sections
  • Adds Spacing() between sections and after each header for breathing room
  • Wraps MCM sub-options (mod name combo + close journal checkbox) in Indent()/Unindent() to visually attach them to the action combo above
  • Simplifies action combo labels from "Start long-press action" / "Back long-press action" to "Action" (section header carries the context)
  • Adds Separator() + Spacing() above the button row
  • All changes confined to RenderSettings() in src/MenuUI.cpp; no logic changes

Test plan

  • Tested in-game — layout renders correctly with section headers, spacing, and indented MCM sub-options
  • Save, reload, and reset all function correctly

Copilot AI review requested due to automatic review settings June 18, 2026 12:40

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the in-game settings menu layout in RenderSettings() to improve readability by grouping related controls into labeled sections, adding spacing/separators, and visually nesting MCM sub-options under their parent action.

Changes:

  • Added section headers (General, Start button, Back button) using ImGuiMCP::SeparatorText() and added Spacing() to improve scanability.
  • Indented MCM-related sub-options with Indent()/Unindent() so they visually attach to the corresponding action selection.
  • Simplified action combo visible labels to Action (with unique ImGui IDs via ##start / ##back) and added a separator + spacing above the Save/Reload/Reset button row.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codepuncher codepuncher merged commit e5630f3 into main Jun 18, 2026
11 checks passed
@codepuncher codepuncher deleted the feat/smf-menu-layout-redesign branch June 18, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants