feat(ui): restructure SMF menu layout with section headers and spacing#58
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the in-game settings menu layout in RenderSettings() to improve readability by grouping related controls into labeled sections, adding spacing/separators, and visually nesting MCM sub-options under their parent action.
Changes:
- Added section headers (
General,Start button,Back button) usingImGuiMCP::SeparatorText()and addedSpacing()to improve scanability. - Indented MCM-related sub-options with
Indent()/Unindent()so they visually attach to the corresponding action selection. - Simplified action combo visible labels to
Action(with unique ImGui IDs via##start/##back) and added a separator + spacing above the Save/Reload/Reset button row.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SeparatorTextheaders (General,Start button,Back button) to divide the flat settings list into named sectionsSpacing()between sections and after each header for breathing roomIndent()/Unindent()to visually attach them to the action combo above"Start long-press action"/"Back long-press action"to"Action"(section header carries the context)Separator()+Spacing()above the button rowRenderSettings()insrc/MenuUI.cpp; no logic changesTest plan