fix(test): fix ActionName pointer comparison in test assertions#57
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes incorrect test assertions that were comparing const char* pointers instead of string contents when validating Config::ActionName, and adds documentation for a planned SMF menu layout redesign.
Changes:
- Update
ActionNametest assertions to compare string contents viastd::string_view. - Add SMF menu layout redesign design spec documentation.
- Add an implementation plan for the SMF menu layout redesign.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/PluginTests.cpp | Fixes ActionName(...) == "literal" pointer comparisons by forcing string comparison with std::string_view. |
| docs/superpowers/specs/2026-06-18-smf-menu-layout-redesign-design.md | Adds a design spec describing a sectioned/indented UI layout for RenderSettings(). |
| docs/superpowers/plans/2026-06-18-smf-menu-layout-redesign.md | Adds an implementation plan and code snippet for the planned RenderSettings() layout changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
codepuncher
force-pushed
the
fix/action-name-test-pointer-comparison
branch
from
40d6263 to
981ffe8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.