fix(mcm): navigator reliability and settings UI fixes#53
Merged
Conversation
…not yet bound; standardize g_modCache to always-overwrite; constexpr GFx paths
There was a problem hiding this comment.
Pull request overview
This PR improves the reliability and performance of MCM navigation and the in-game settings UI by fixing cache invalidation/refresh behaviors and reducing per-frame overhead in GFx path handling and mod-name retrieval.
Changes:
- Fixes SkyUI/framework detection and Papyrus-cache scheduling so MCM caching/navigation can recover from transient initialization states.
- Replaces runtime GFx path string concatenations with constexpr full-path constants and standardizes mod-cache overwrite behavior from GFx snapshots.
- Updates the settings UI to snapshot the cached mod-name list only when the dropdown opens (reducing mutex contention per frame).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/MenuUI.cpp | Updates framework-installed detection caching and snapshots mod dropdown options on open rather than per-frame. |
| src/MCMNavigator.cpp | Introduces constexpr GFx path constants, overwrites mod cache consistently from GFx, and resets eager Papyrus scheduling on unbound manager. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fd711a4 to
cae2ce6
Compare
cae2ce6 to
9b3d4f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
g_papyrusEagerScheduledwhenSKI_ConfigManageris not yet bound, allowingEnsureCachePopulatedto retry on the next call rather than wedging permanentlyg_modCachewrite policy inOpenModto always-overwrite instead of write-once, so a later GFx snapshot supersedes a stale oneIsFrameworkInstalledto cache only on a positive result — previously astatic const boolevaluated once at startup before the framework was loaded, silently disabling the UIstd::stringconcatenations for GFx paths withconstexprfull-path constants, eliminating per-call heap allocations on navigation and animation-poll pathsGetCachedModNamesonce when the mod dropdown opens rather than re-acquiring the mutex on every rendered framePart of the June 2026 audit fix series (#51, #52).
Test plan
./scripts/build.sh)