[김미진]Week5#213
Open
mijin0928 wants to merge 8 commits into
Hidden character warning
The head ref may contain hidden characters: "part1-\uae40\ubbf8\uc9c4-week5"
Open
Conversation
- label태그의 for값과 input태그의 id값 수정 - form태그안에 div태그의 클래스명 수정 - 파일경로 수정
refactor(mentor): - / 제거했습니다
refactor(mentor) - 모듈 적용 - 수정사항 반영하여 코드 리팩토링
mijin0928
force-pushed
the
part1-김미진-week5
branch
from
d5835f2 to
0591d6e
Compare
mijin0928
force-pushed
the
part1-김미진-week5
branch
from
0591d6e to
7d83e0f
Compare
| // 눈 아이콘 클릭 시 이미지 및 타입 변경 | ||
| function eyeToggle(e){ | ||
| e.preventDefault(); | ||
|
|
Collaborator
There was a problem hiding this comment.
indexOf도 틀린건 아니지만 맥락상으로는 includes가 더 맞겠네요. 아래처럼 별도의 분기처리(if, else)없이 리팩토링 가능합니다.
const eyeIconSrc = e.target.src.includes('off') ? "./images/ico-eye-on.svg" : "./images/ico-eye-off.svg";
const passwordInputType = e.target.src.includes('off') ? "password" : "text";
e.target.src = eyeIconSrc;
pwInput.type = passwordInputType; |
|
||
| if(localStorage.getItem('accessToken')) join(email, password); | ||
| }catch(error){ | ||
| console.log(error); |
Collaborator
There was a problem hiding this comment.
단순히 console을 찍을게 아닌, 사용자에게 에러가 났으니 다시 어떤 행동을 하도록 유도해주셔합니다. (ex. 새로고침)
| @@ -0,0 +1,65 @@ | |||
| const pwCheckInput = document.getElementById('signup-check-password'); | |||
| const correct = { | |||
Collaborator
There was a problem hiding this comment.
pattern과 userInfo는 다른 성질의 데이터입니다. 분리해주세요.
Collaborator
: 409오류는 Status 의미로 "Confilct" 입니다. 일단은 HttpStatusCode에 대한 이해가 필요하고, 중복된 데이터를 보내서 충돌이 일어났을 때 해당에러를 내뱉는 경우가 맞다면, 오류라고 볼 수 없고 서버에서 의도한 에러라고 판단해야됩니다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
멘토에게