Moved frontend from FS extension and added Joblog command#3348
Open
buzzia2001 wants to merge 2 commits into
Open
Moved frontend from FS extension and added Joblog command#3348buzzia2001 wants to merge 2 commits into
buzzia2001 wants to merge 2 commits into
Conversation
SanjulaGanepola
requested changes
Jul 10, 2026
SanjulaGanepola
left a comment
SanjulaGanepola
left a comment
Member
There was a problem hiding this comment.
Works great! Just left some minor comments
| const EMPTY_VALUE_PLACEHOLDER = '<span style="color: var(--vscode-descriptionForeground); font-style: italic;">—</span>'; | ||
|
|
||
| /** Escape a value for safe interpolation into the generated HTML. */ | ||
| function escapeHtml(text: string | number): string { |
Member
There was a problem hiding this comment.
The map logic looks very similar to Tools.escapeHtml. Should we call that here?
|
|
||
| /** | ||
| * Generate an enhanced detail table (key-value pairs) using Fast components | ||
| * This is a modern replacement for generateTableHtml and generateTableHtmlCode |
Member
There was a problem hiding this comment.
generateTableHtml and generateTableHtmlCode is mentioned here in this comment, but not sure what that is reffering too.
Member
Author
|
Ciao @SanjulaGanepola, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR moves the table generation functions from the FS extension to the core. The FS extension now imports the methods exported by the core. Exporting the table generation also ensures a consistent UI even when other extensions are used.
In addition, the ‘IBM i: Display Job Log’ command has been added, which allows you to view the job log of an active job. The command is pre-populated by default with the name of the current job.
@NicolasSchindler this PR allows you to proceed with #3346.
How to test this PR
Checklist
console.logs I added