Fixed errors being stacked when reported on multiple files#3347
Merged
Conversation
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
sebjulliand
added
the
bug
Contributor
|
👋 A new build is available for this PR based on 8090f57. |
Member
|
It works fine, thank you @sebjulliand for the resolution and many thanks to @SJLennon that create an easy test case |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #3345
This PR fixes a bug in the loop gathering the errors for each files from EVFEVENT. The
diagnosticsarray was not cleared after each iteration, so the errors would be stacked and reported for each subsequent member being processed.Now the array is cleared and errors are only reported on the member they belong to.
How to test this PR
Checklist