Skip to content

Fix confirmation message for multiple downloads#3343

Merged
sebjulliand merged 1 commit into
codefori:masterfrom
buzzia2001:fixIfsMultipleDownload
Jul 2, 2026
Merged

Fix confirmation message for multiple downloads#3343
sebjulliand merged 1 commit into
codefori:masterfrom
buzzia2001:fixIfsMultipleDownload

Conversation

@buzzia2001

Copy link
Copy Markdown
Member

Changes

With this PR, the modal for confirming file overwrites in multiple downloads has now been fixed. Before this fix, the entire message was displayed in the confirmation button

How to test this PR

  1. Connect to an IBM i, open the IFS Browser.
  2. Go to an IFS folder containing at least 2 files (streamfiles).
  3. Select two or more files using Ctrl/Shift+click.
  4. Right-click → Download, then choose a local destination folder.
  5. Let the download complete (those files now exist locally in the folder you chose).
  6. Repeat steps 3–4 by selecting the same files again and choosing the same destination folder. Now you'll have a modal with YES

Checklist

  • have tested my change
  • have created one or more test cases
  • updated relevant documentation
  • Remove any/all console.logs I added
  • have added myself to the contributors' list in CONTRIBUTING.md

@buzzia2001 buzzia2001 requested a review from a team July 1, 2026 19:56
@buzzia2001 buzzia2001 self-assigned this Jul 1, 2026
@buzzia2001 buzzia2001 added the bug A confirmed issue when something isn't working as intended label Jul 1, 2026

@sebjulliand sebjulliand left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sebjulliand sebjulliand merged commit 5b93e51 into codefori:master Jul 2, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug A confirmed issue when something isn't working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants