Enhance action sorting options for actions#3342
Conversation
sebjulliand
left a comment
There was a problem hiding this comment.
Thanks for looking into this @buzzia2001 .
However, that change breaks the UX.
- Actions should not be hidden based on which sorting order is selected - especially if the user is working on local projects and members alike.
- Choosing
configrenders the local actions unusable from a local project - Choosing
actionsFileshows a warning every time an action is run on a member or IFS file
For example, I usually work in a hybrid environment, with a local project opened in VS Code but I also work on members at the same time. I don't see myself going back and forth in the settings to change the sorting order 😉
Besides, it's about sorting, this should not hide anything.
So, I'd suggest you just keep the config option that will sort actions in the order they are defined in the configuration, regardless of their origin.
Thanks!
|
Hi @sebjulliand , Thank you for your suggestion |
sebjulliand
left a comment
There was a problem hiding this comment.
Greta job @buzzia2001 , thanks for the modification.
I just made a couple of suggestions to make the code more explicit.
We'll merge after that.
|
I followed your advice, and I've pushed |
sebjulliand
left a comment
There was a problem hiding this comment.
Many thanks @buzzia2001
Changes
This PR introduces support for displaying actions in four ways:
How to test this PR
Change Code-for-ibmi: Sort Actions By in Preferences, now you'll see actions depending on what you decide to sort:
Checklist
console.logs I addedCloses #3338