Skip to content

Enhance action sorting options for actions#3342

Merged
sebjulliand merged 3 commits into
codefori:masterfrom
buzzia2001:featOrderActions
Jul 5, 2026
Merged

Enhance action sorting options for actions#3342
sebjulliand merged 3 commits into
codefori:masterfrom
buzzia2001:featOrderActions

Conversation

@buzzia2001

Copy link
Copy Markdown
Member

Changes

This PR introduces support for displaying actions in four ways:

  1. by usage
  2. by name
  3. based on the original configuration file
  4. based on the actions.jso file

How to test this PR

Change Code-for-ibmi: Sort Actions By in Preferences, now you'll see actions depending on what you decide to sort:

image

Checklist

  • have tested my change
  • have created one or more test cases
  • updated relevant documentation
  • Remove any/all console.logs I added
  • have added myself to the contributors' list in CONTRIBUTING.md

Closes #3338

@buzzia2001 buzzia2001 requested a review from a team July 1, 2026 19:44
@buzzia2001 buzzia2001 self-assigned this Jul 1, 2026
@buzzia2001 buzzia2001 added the enhancement New feature or request label Jul 1, 2026

@sebjulliand sebjulliand left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this @buzzia2001 .

However, that change breaks the UX.

  • Actions should not be hidden based on which sorting order is selected - especially if the user is working on local projects and members alike.
  • Choosing config renders the local actions unusable from a local project
  • Choosing actionsFile shows a warning every time an action is run on a member or IFS file

For example, I usually work in a hybrid environment, with a local project opened in VS Code but I also work on members at the same time. I don't see myself going back and forth in the settings to change the sorting order 😉

Besides, it's about sorting, this should not hide anything.

So, I'd suggest you just keep the config option that will sort actions in the order they are defined in the configuration, regardless of their origin.

Thanks!

@buzzia2001

Copy link
Copy Markdown
Member Author

Hi @sebjulliand ,
to you.

Thank you for your suggestion

@sebjulliand sebjulliand left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greta job @buzzia2001 , thanks for the modification.
I just made a couple of suggestions to make the code more explicit.
We'll merge after that.

Comment thread src/ui/actions.ts Outdated
Comment thread src/ui/actions.ts Outdated
@buzzia2001

Copy link
Copy Markdown
Member Author

I followed your advice, and I've pushed

@buzzia2001 buzzia2001 requested a review from sebjulliand July 5, 2026 18:15

@sebjulliand sebjulliand left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks @buzzia2001 ☺️

@sebjulliand sebjulliand merged commit ff7c96c into codefori:master Jul 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sort by Natural order for actions from actions.json

2 participants