Fix download source file

[buzzia2001]

Changes

This PR fixes a bug that occurs if you download two source files with different record format within the same session.

How to test this PR

1. download a member with small size (92)
2. download a member with bigger size (100)

Checklist

• have tested my change
• have created one or more test cases
• updated relevant documentation
• Remove any/all console.logs I added
• have added myself to the contributors' list in CONTRIBUTING.md

Closes #3340

[bobcozzi]

Good, you added a DROP IF EXISTS to delete any existing prior temp file. The CPYF CRTFILE(*YES) will create the new one. Looks correct to me. But what if you made the target of the CPYF be the same member name as the source member? That way it is identified if the code needs to be debugged by the user or by us then we would know the member name. Since we now delete it always, it would be a good change to make it TOMBR(${item.member.name}).
This last bit is just a suggestion, now a functional enhancement.

[bobcozzi]

You know... I need to test this but what if someone has say 10 developers using CODEfori and they try to download at the same time, and they are use MAPEPIRE SERVER mode?
Since they're using that same submitted job, wouldn't they share QTEMP? Therefore, the CPYF to QTEMP would have an issue/conflict with the name always being the say, wouldn't it?

[buzzia2001]

You know... I need to test this but what if someone has say 10 developers using CODEfori and they try to download at the same time, and they are use MAPEPIRE SERVER mode?
Since they're using that same submitted job, wouldn't they share QTEMP? Therefore, the CPYF to QTEMP would have an issue/conflict with the name always being the say, wouldn't it?

Nope, server mode open a dedicated QZDASOINIT (QZDASSINIT) for each client

[sebjulliand]

Works fine.
I was thinking we could regroup the members by files and delete the file before copying each set but the performance gain seems negligible since create or replace is quite fast here.

Approved and merged, thanks @buzzia2001 !