feat: transition type annotations on connections#18
Merged
trmquang93 merged 1 commit intomainfrom Apr 1, 2026
Merged
Conversation
Exposes the existing transitionType field with an expanded set of transition options (push, modal, fullScreenCover, replace, pop, tab, fade, slideUp, slideLeft, custom) in both ConnectionEditModal and HotspotModal. Extracts TRANSITION_TYPES and TRANSITION_LABELS to constants.js as a single source of truth. Canvas connection badges now render a distinct SVG icon alongside the transition label so types are visually distinguishable at a glance. Navigation.md outputs human-readable transition labels. Build-guide.md includes a platform-specific Transition Types table for all four supported frameworks (SwiftUI, React Native, Flutter, Jetpack Compose) as well as expanded per-type guidance in the auto-platform path. No file format change — transitionType field already exists and importFlow.js already backfills it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fullScreenCover,fade,slideUp,slideLeft) and extracts them toconstants.jsas a single source of truth — eliminates duplicate hardcoded<option>lists inConnectionEditModalandHotspotModalnavigation.mdnow outputs human-readable transition labels (e.g. "Full-screen cover" instead offullScreenCover)build-guide.mdincludes a Transition Types table with platform-specific implementation patterns for all 4 frameworks (SwiftUI, React Native, Flutter, Jetpack Compose), and expands the auto-platform path with per-type guidanceNo file format change —
transitionTypefield already exists andimportFlow.jsalready backfills it for older files.Closes backlog item 1.4 — Animation & Transition Annotations.
Test plan
npm run lint && npm test— all 292 tests pass, no lint errorsswiftui— verifybuild-guide.mdcontains### Transition Typestable with.sheet(),.fullScreenCover(), etc.auto— verify step 7 lists all transition typesnavigation.mdAll Connections table shows "Full-screen cover" notfullScreenCover