Release/260408

.github/workflows/build-multiplatform.yml

@@ -30,7 +30,7 @@ jobs:
       - name: Setup Bun
         uses: oven-sh/setup-bun@v2
         with:
-          bun-version: latest
+          bun-version: '1.3.10'
 
       - name: Cache Bun dependencies
         uses: actions/cache@v4

.github/workflows/ci.yml

@@ -22,7 +22,7 @@ jobs:
       - name: Setup Bun
         uses: oven-sh/setup-bun@v2
         with:
-          bun-version: latest
+          bun-version: '1.3.10'
 
       - name: Cache Bun dependencies
         uses: actions/cache@v4
@@ -76,7 +76,7 @@ jobs:
       - name: Setup Bun
         uses: oven-sh/setup-bun@v2
         with:
-          bun-version: latest
+          bun-version: '1.3.10'
 
       - name: Cache Bun dependencies
         uses: actions/cache@v4

.github/workflows/release.yml

@@ -120,7 +120,7 @@ jobs:
       - name: Setup Bun
         uses: oven-sh/setup-bun@v2
         with:
-          bun-version: latest
+          bun-version: '1.3.10'
 
       - name: Cache Bun dependencies
         uses: actions/cache@v4
@@ -392,32 +392,3 @@ jobs:
             merged/latest.json
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-
-  upgradelink-upload:
-    needs: release
-    permissions:
-      contents: read
-    runs-on: ubuntu-22.04
-    steps:
-      - name: Resolve release tag
-        id: release_meta
-        shell: bash
-        env:
-          TAG_NAME: ${{ inputs.tag || github.ref_name }}
-        run: |
-          set -euo pipefail
-          echo "release_tag=${TAG_NAME}" >> "$GITHUB_OUTPUT"
-
-      - name: Upload latest.json to UpgradeLink
-        uses: toolsetlink/upgradelink-action@3.0.2
-        with:
-          access_key: ${{ secrets.UPGRADE_LINK_ACCESS_KEY }}
-          access_secret: ${{ secrets.UPGRADE_LINK_ACCESS_SECRET }}
-          config: |
-            {
-              "app_type": "tauri",
-              "request": {
-                "app_key": "${{ secrets.UPGRADE_LINK_TAURI_KEY }}",
-                "latest_json_url": "https://github.com/${{ github.repository }}/releases/download/${{ steps.release_meta.outputs.release_tag }}/latest.json"
-              }
-            }

.github/workflows/upgradelink-upload.yml

@@ -0,0 +1,29 @@
+name: UpgradeLink Upload
+
+on:
+  workflow_dispatch:
+    inputs:
+      tag:
+        description: "Release tag to upload (e.g. v1.2.3)"
+        required: true
+        type: string
+
+jobs:
+  upgradelink-upload:
+    permissions:
+      contents: read
+    runs-on: ubuntu-22.04
+    steps:
+      - name: Upload latest.json to UpgradeLink
+        uses: toolsetlink/upgradelink-action@3.0.2
+        with:
+          access_key: ${{ secrets.UPGRADE_LINK_ACCESS_KEY }}
+          access_secret: ${{ secrets.UPGRADE_LINK_ACCESS_SECRET }}
+          config: |
+            {
+              "app_type": "tauri",
+              "request": {
+                "app_key": "${{ secrets.UPGRADE_LINK_TAURI_KEY }}",
+                "latest_json_url": "https://github.com/${{ github.repository }}/releases/download/${{ inputs.tag }}/latest.json"
+              }
+            }

package.json

@@ -5,7 +5,7 @@
     "url": "git+https://github.com/codeErrorSleep/dbpaw.git"
   },
   "private": true,
-  "version": "0.3.2",
+  "version": "0.3.3",
   "type": "module",
   "scripts": {
     "dev": "vite",

scripts/test-integration.sh

@@ -39,6 +39,10 @@ case "${it_db}" in
     run_integration_test "mysql_command_integration"
     run_integration_test "mysql_stateful_command_integration"
     ;;
+  starrocks)
+    run_integration_test "starrocks_integration"
+    run_integration_test "starrocks_command_integration"
+    ;;
   mariadb)
     run_integration_test "mariadb_integration"
     run_integration_test "mariadb_command_integration"
@@ -89,7 +93,7 @@ case "${it_db}" in
     run_integration_test "oracle_command_integration"
     ;;
   *)
-    echo "[error] Invalid IT_DB='${it_db}'. Expected one of: mysql|mariadb|postgres|clickhouse|mssql|duckdb|sqlite|oracle|all"
+    echo "[error] Invalid IT_DB='${it_db}'. Expected one of: mysql|starrocks|mariadb|postgres|clickhouse|mssql|duckdb|sqlite|oracle|all"
     exit 1
     ;;
 esac

src-tauri/Cargo.toml

@@ -18,7 +18,7 @@ crate-type = ["staticlib", "cdylib", "rlib"]
 tauri-build = { version = "2", features = [] }
 
 [dependencies]
-tauri = { version = "2", features = [] }
+tauri = { version = "2", features = ["devtools"] }
 tauri-plugin-opener = "2"
 tauri-plugin-dialog = "2"
 tauri-plugin-fs = "2"

src-tauri/src/commands/connection.rs

@@ -267,7 +267,7 @@ pub async fn create_database_by_id(
     }
 
     let exec_res = match driver.as_str() {
-        "mysql" | "mariadb" | "tidb" => {
+        driver if crate::db::drivers::is_mysql_family_driver(driver) => {
             let sql = build_mysql_create_database_sql(&payload, &db_name)?;
             super::execute_with_retry(&state, id, None, |driver| {
                 let sql_clone = sql.clone();
@@ -348,7 +348,7 @@ pub async fn create_database_by_id_direct(
     }
 
     let exec_res = match driver.as_str() {
-        "mysql" | "mariadb" | "tidb" => {
+        driver if crate::db::drivers::is_mysql_family_driver(driver) => {
             let sql = build_mysql_create_database_sql(&payload, &db_name)?;
             super::execute_with_retry_from_app_state(state, id, None, |driver| {
                 let sql_clone = sql.clone();
@@ -419,6 +419,122 @@ pub async fn test_connection_ephemeral(
     })
 }
 
+#[tauri::command]
+pub async fn get_mysql_charsets_by_id(
+    state: State<'_, AppState>,
+    id: i64,
+) -> Result<Vec<String>, String> {
+    super::execute_with_retry(&state, id, None, |driver| async move {
+        let result = driver
+            .execute_query("SHOW CHARACTER SET".to_string())
+            .await?;
+        let mut charsets: Vec<String> = result
+            .data
+            .iter()
+            .filter_map(|row| {
+                row.get("Charset")
+                    .and_then(|v| v.as_str())
+                    .map(|s| s.to_string())
+            })
+            .collect();
+        charsets.sort();
+        Ok(charsets)
+    })
+    .await
+}
+
+#[tauri::command]
+pub async fn get_mysql_collations_by_id(
+    state: State<'_, AppState>,
+    id: i64,
+    charset: Option<String>,
+) -> Result<Vec<String>, String> {
+    let sql = match &charset {
+        Some(cs) if is_safe_option_token(cs) => {
+            format!("SHOW COLLATION WHERE Charset = '{}'", cs)
+        }
+        Some(cs) => {
+            return Err(format!("[VALIDATION_ERROR] Invalid charset: {}", cs));
+        }
+        None => "SHOW COLLATION".to_string(),
+    };
+    super::execute_with_retry(&state, id, None, |driver| {
+        let sql = sql.clone();
+        async move {
+            let result = driver.execute_query(sql).await?;
+            let mut collations: Vec<String> = result
+                .data
+                .iter()
+                .filter_map(|row| {
+                    row.get("Collation")
+                        .and_then(|v| v.as_str())
+                        .map(|s| s.to_string())
+                })
+                .collect();
+            collations.sort();
+            Ok(collations)
+        }
+    })
+    .await
+}
+
+pub async fn get_mysql_charsets_by_id_direct(
+    state: &AppState,
+    id: i64,
+) -> Result<Vec<String>, String> {
+    super::execute_with_retry_from_app_state(state, id, None, |driver| async move {
+        let result = driver
+            .execute_query("SHOW CHARACTER SET".to_string())
+            .await?;
+        let mut charsets: Vec<String> = result
+            .data
+            .iter()
+            .filter_map(|row| {
+                row.get("Charset")
+                    .and_then(|v| v.as_str())
+                    .map(|s| s.to_string())
+            })
+            .collect();
+        charsets.sort();
+        Ok(charsets)
+    })
+    .await
+}
+
+pub async fn get_mysql_collations_by_id_direct(
+    state: &AppState,
+    id: i64,
+    charset: Option<String>,
+) -> Result<Vec<String>, String> {
+    let sql = match &charset {
+        Some(cs) if is_safe_option_token(cs) => {
+            format!("SHOW COLLATION WHERE Charset = '{}'", cs)
+        }
+        Some(cs) => {
+            return Err(format!("[VALIDATION_ERROR] Invalid charset: {}", cs));
+        }
+        None => "SHOW COLLATION".to_string(),
+    };
+    super::execute_with_retry_from_app_state(state, id, None, |driver| {
+        let sql = sql.clone();
+        async move {
+            let result = driver.execute_query(sql).await?;
+            let mut collations: Vec<String> = result
+                .data
+                .iter()
+                .filter_map(|row| {
+                    row.get("Collation")
+                        .and_then(|v| v.as_str())
+                        .map(|s| s.to_string())
+                })
+                .collect();
+            collations.sort();
+            Ok(collations)
+        }
+    })
+    .await
+}
+
 #[tauri::command]
 pub async fn get_connections(state: State<'_, AppState>) -> Result<Vec<Connection>, String> {
     let local_db = {
@@ -553,8 +669,8 @@ mod tests {
         validate_database_name, CreateDatabasePayload,
     };
     use super::{
-        normalize_create_database_error, normalize_option_token, quote_clickhouse_ident,
-        quote_mssql_ident, quote_mysql_ident, quote_pg_ident,
+        is_safe_option_token, normalize_create_database_error, normalize_option_token,
+        quote_clickhouse_ident, quote_mssql_ident, quote_mysql_ident, quote_pg_ident,
     };
     use crate::connection_input::normalize_connection_form;
     use crate::models::ConnectionForm;
@@ -734,4 +850,52 @@ mod tests {
         .unwrap_err();
         assert!(err.contains("does not support charset option"));
     }
+
+    #[test]
+    fn get_mysql_collations_charset_validation_rejects_unsafe_tokens() {
+        // Verify the validation logic used by get_mysql_collations_by_id/_direct.
+        // A charset with spaces or semicolons must be rejected.
+        assert!(!is_safe_option_token("utf8 mb4"));
+        assert!(!is_safe_option_token("utf8;drop"));
+        assert!(!is_safe_option_token(""));
+    }
+
+    #[test]
+    fn get_mysql_collations_charset_validation_accepts_valid_charsets() {
+        // All standard MySQL charset names must pass the token check.
+        let valid = [
+            "utf8mb4",
+            "utf8",
+            "latin1",
+            "gbk",
+            "gb18030",
+            "ascii",
+            "binary",
+            "utf8mb4_0900_ai_ci",
+        ];
+        for cs in valid {
+            assert!(is_safe_option_token(cs), "expected '{}' to be accepted", cs);
+        }
+    }
+
+    #[test]
+    fn mysql_create_database_sql_is_reusable_for_starrocks_connections() {
+        assert!(crate::db::drivers::is_mysql_family_driver("starrocks"));
+
+        let sql = build_mysql_create_database_sql(
+            &CreateDatabasePayload {
+                name: "analytics".to_string(),
+                if_not_exists: Some(true),
+                charset: None,
+                collation: None,
+                encoding: None,
+                lc_collate: None,
+                lc_ctype: None,
+            },
+            "analytics",
+        )
+        .unwrap();
+
+        assert_eq!(sql, "CREATE DATABASE IF NOT EXISTS `analytics`");
+    }
 }