-
-
Notifications
You must be signed in to change notification settings - Fork 53
Make routes tab great again #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
d5684da
Make routes tab great again
AlemTuzlak 783d160
small bug fix
AlemTuzlak ce1c7a0
fix for custom ids
AlemTuzlak 56347b4
optimize the recursive routes call
AlemTuzlak bc0a9f0
fix for custom ids
AlemTuzlak e55836d
fix
AlemTuzlak d83fb11
fix
AlemTuzlak ea83c3d
please God
AlemTuzlak 307cf72
fix
AlemTuzlak 0652151
fix
AlemTuzlak 1d41d26
logs
AlemTuzlak fa8b264
test
AlemTuzlak aed7908
test
AlemTuzlak a7d7c53
remove logs
AlemTuzlak 674871e
version bump
AlemTuzlak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this change intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes,it was a mistake to start over from v1 on react-router-devtools as most of the v2-v4 version range was taken by remix-development-tools on this repo so I moved it to 5 to allow for easier releases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @AlemTuzlak!
Thank you for confirming this information. We're in the process of upgrading to the latest version and noticed this represents a significant version jump. I was interested in understanding the rationale behind this major bump from 1.x to 5.x.
Is this transition documented somewhere? It would be valuable to share this context with customers and users who are planning similar upgrades to ensure a smooth transition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fkoner sorry I missed this comment, the reason behind it is that this repo used to be remix-development-tools which has a lot of existing releases in the 2-4 range so I decided to skip to 5 so I don't break releases due to duplicate versions. I should've started from the beginning with v5