Conversation
…, and some fixes in sidebar, toc and ocumentation page
AlemTuzlak
reviewed
Sep 1, 2025
| getLatestVersion: () => "v1.0.0", | ||
| isKnownVersion: (v?: string) => v === "v1.0.0", | ||
| // not used here, but we will keeping for consistency | ||
| hrefForHomepage: (v: string) => (v === "v1.0.0" ? "/home" : `/${v}/home`), |
Collaborator
There was a problem hiding this comment.
you can use ...await vi.importActual("module") to use the real modules IF needed, if not just don't mock it, no need
AlemTuzlak
reviewed
Sep 1, 2025
| // biome-ignore lint/suspicious/noExplicitAny: we can use any in tests | ||
| const result = buildBreadcrumb(items as any, "/v1/started/unknown") | ||
| // biome-ignore lint/suspicious/noExplicitAny: we can use `any` here | ||
| const result = buildBreadcrumb(items as any, "/v1.0.0/getting-started/unknown") |
Collaborator
There was a problem hiding this comment.
why do you use any here? just because it's a test doesn't mean we should use any to get around typescript, if it's to avoid crazy nested subproperties with a lot of fields it can be done but if it's just to save 5 minutes you shouldn't do that
thomasfr
suggested changes
Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #7
Description:
From https://github.com/forge-42/docs-template-example:
recording-2025-08-21-15-35-13.webm