add meetup component with API call#2
Open
dotis90 wants to merge 1 commit intocode-for-syracuse:masterfrom
dotis90:feature/meetup-integration
Open
add meetup component with API call#2dotis90 wants to merge 1 commit intocode-for-syracuse:masterfrom dotis90:feature/meetup-integration
dotis90 wants to merge 1 commit intocode-for-syracuse:masterfrom
dotis90:feature/meetup-integration
Conversation
1egoman
reviewed
Jul 11, 2020
| "https://www.meetup.com/Syracuse-Software-Development-Meetup/events/json/" | ||
|
|
||
| useEffect(() => { | ||
| fetch(corsAPI + meetupURL, { |
Member
There was a problem hiding this comment.
It might be a good idea to url encode meetupURL in this situation: corsAPI + encodeURIComponent(meetupUrl). I'm not 100% sure on this, it's just a hunch and in practice it may not matter.
1egoman
approved these changes
Jul 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a meetup component that makes a call to an API to get the information for upcoming events. I needed to use an additional cors API to get access to the data, otherwise it was inaccessible. It's just one solution to getting the data, though it may just be a temporary one. I am getting the data from Syracuse Software Meetup, and currently there are no Code for Syracuse meetings listed. Once they become available, I think I will be able to filter out the Code for Syracuse events by title, put them into a new array, and then only display the first element, or all of them depending on how much we want to show.
I'm sure I can find a library/libraries to help us with formatting the event dates too.