Bump Solana toolchain to 3.1.14 to fix edition2024 build failure#1003
Closed
lorisleiva wants to merge 1 commit into
Closed
Bump Solana toolchain to 3.1.14 to fix edition2024 build failure#1003lorisleiva wants to merge 1 commit into
lorisleiva wants to merge 1 commit into
Conversation
Solana 3.1.8's bundled Cargo (1.84.0) cannot parse `blake3 1.8.3`'s manifest because it requires the `edition2024` Cargo feature (stabilized in Rust 1.85). The transitive crate slid forward via the resolver and broke the `@codama/dynamic-client#test` step on main after PR #994 was merged; the merge itself was unrelated and only retriggered CI. Bumps `SOLANA_VERSION` from 3.1.8 to 3.1.14, the latest patch in the 3.1 line, which ships Rust 1.86 — enough to support edition 2024. No other changes.
|
Member
Author
|
Superseded by a new PR with the corrected approach: lockfile-only pin of blake3 to 1.8.2 (the SOLANA_VERSION bump was a no-op for this failure since the bundled platform-tools Cargo isn't controlled by the agave CLI version). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bumps
SOLANA_VERSIONin.github/workflows/main.ymlfrom3.1.8to3.1.14to clear a transitive-dependency build failure that started hittingmainafter PR #994 was merged.Root cause
The failure in this run is unrelated to the merge content. While compiling the anchor test programs in
@codama/dynamic-client#test, Cargo failed with:blake3is pulled in transitively via the Solana program crates.blake3 1.8.3was published recently and requires Rust edition 2024 (stabilized in 1.85). Solana 3.1.8 ships its bundled Cargo at1.84.0— the workflow'sRUST_VERSION: 1.93.0only controls the host toolchain, not the Solana-bundled one used for SBPF builds.The merge of #994 didn't cause the breakage; it just retriggered CI on a fresh runner that re-resolved
blake3to the new version. Any push around this time would have hit the same wall.Fix
Bump
SOLANA_VERSIONfrom3.1.8to3.1.14. The latter is the latest patch in the 3.1 line and ships Rust 1.86 (verified against agave's v3.1.14rust-toolchain.toml), which supports edition 2024 and parsesblake3 1.8.3cleanly.3.1.14 is a patch-level release containing backports of fixes plus the Rust toolchain bump (release notes are linked in the agave 3.1.14 release page). No breaking changes vs. 3.1.8.
Alternatives considered
blake3to=1.8.2in the anchor Cargo.lock. Narrower fix but adds a sticky lockfile entry that future Solana SDK updates would have to keep tolerating. Fragile.3.1.14 is the minimum-risk change that resolves the immediate problem.
Verification
Local repo changes: a single line in
.github/workflows/main.yml. CI will exercise the actual bumped toolchain — that's the relevant verification.Marked draft so you can review the diagnosis and pick the fix path before pushing it through.