Skip to content

Bump Solana toolchain to 3.1.14 to fix edition2024 build failure#1003

Closed
lorisleiva wants to merge 1 commit into
mainfrom
06-02-bump_solana_toolchain_to_3.1.14_to_fix_edition2024_build_failure
Closed

Bump Solana toolchain to 3.1.14 to fix edition2024 build failure#1003
lorisleiva wants to merge 1 commit into
mainfrom
06-02-bump_solana_toolchain_to_3.1.14_to_fix_edition2024_build_failure

Conversation

@lorisleiva

Copy link
Copy Markdown
Member

This PR bumps SOLANA_VERSION in .github/workflows/main.yml from 3.1.8 to 3.1.14 to clear a transitive-dependency build failure that started hitting main after PR #994 was merged.

Root cause

The failure in this run is unrelated to the merge content. While compiling the anchor test programs in @codama/dynamic-client#test, Cargo failed with:

error: failed to parse manifest at `.../blake3-1.8.3/Cargo.toml`
Caused by:
  feature `edition2024` is required
  The package requires the Cargo feature called `edition2024`, but that feature
  is not stabilized in this version of Cargo (1.84.0 (12fe57a9d 2025-04-07)).

blake3 is pulled in transitively via the Solana program crates. blake3 1.8.3 was published recently and requires Rust edition 2024 (stabilized in 1.85). Solana 3.1.8 ships its bundled Cargo at 1.84.0 — the workflow's RUST_VERSION: 1.93.0 only controls the host toolchain, not the Solana-bundled one used for SBPF builds.

The merge of #994 didn't cause the breakage; it just retriggered CI on a fresh runner that re-resolved blake3 to the new version. Any push around this time would have hit the same wall.

Fix

Bump SOLANA_VERSION from 3.1.8 to 3.1.14. The latter is the latest patch in the 3.1 line and ships Rust 1.86 (verified against agave's v3.1.14 rust-toolchain.toml), which supports edition 2024 and parses blake3 1.8.3 cleanly.

3.1.14 is a patch-level release containing backports of fixes plus the Rust toolchain bump (release notes are linked in the agave 3.1.14 release page). No breaking changes vs. 3.1.8.

Alternatives considered

  • Pin blake3 to =1.8.2 in the anchor Cargo.lock. Narrower fix but adds a sticky lockfile entry that future Solana SDK updates would have to keep tolerating. Fragile.
  • Bump to Solana 4.x. Aligns the bundled Rust with the host (1.93.x), but 4.0 is a major release with API/SBPF changes that could affect the anchor test programs. Out of scope for a "fix CI" PR.

3.1.14 is the minimum-risk change that resolves the immediate problem.

Verification

Local repo changes: a single line in .github/workflows/main.yml. CI will exercise the actual bumped toolchain — that's the relevant verification.

Marked draft so you can review the diagnosis and pick the fix path before pushing it through.

Solana 3.1.8's bundled Cargo (1.84.0) cannot parse `blake3 1.8.3`'s manifest because it requires the `edition2024` Cargo feature (stabilized in Rust 1.85). The transitive crate slid forward via the resolver and broke the `@codama/dynamic-client#test` step on main after PR #994 was merged; the merge itself was unrelated and only retriggered CI. Bumps `SOLANA_VERSION` from 3.1.8 to 3.1.14, the latest patch in the 3.1 line, which ships Rust 1.86 — enough to support edition 2024. No other changes.
@changeset-bot

changeset-bot Bot commented Jun 2, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 0e5a23e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lorisleiva

Copy link
Copy Markdown
Member Author

Superseded by a new PR with the corrected approach: lockfile-only pin of blake3 to 1.8.2 (the SOLANA_VERSION bump was a no-op for this failure since the bundled platform-tools Cargo isn't controlled by the agave CLI version).

@lorisleiva lorisleiva closed this Jun 2, 2026
@lorisleiva lorisleiva deleted the 06-02-bump_solana_toolchain_to_3.1.14_to_fix_edition2024_build_failure branch June 2, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant